Try 2 is rebased against the latest changes.
Clipboard handling is unified with the previous code in editor.c. Manual tests show trying to cut from a read-only field beeps when using WM_CUT or Ctrl+X, but not when using these APIs.
Signed-off-by: Damjan Jovanovic damjan.jov@gmail.com --- dlls/riched20/caret.c | 2 +- dlls/riched20/editor.c | 51 +++++++++++++++--------- dlls/riched20/editor.h | 3 +- dlls/riched20/richole.c | 46 ++++++++++++++++++---- dlls/riched20/tests/richole.c | 74 +++++++++++++++++++++++++++++++++++ 5 files changed, 148 insertions(+), 28 deletions(-)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=80432
Your paranoid android.
=== debiant (32 bit report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
=== debiant (32 bit French report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
=== debiant (32 bit Japanese:Japan report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
=== debiant (32 bit Chinese:China report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
=== debiant (32 bit WoW report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
=== debiant (64 bit WoW report) ===
riched20: richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4064: Test failed: unexpected contents: "" richole.c:4070: Test failed: Cut failed: 0x80070005 richole.c:4027: Test failed: Copy failed: 0x80070005 richole.c:4071: Test failed: unexpected contents: "" richole.c:4027: Test failed: Copy failed: 0x80070005
-
Damjan Jovanovic -
Marvin