Re: [PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)

[Alexandre Julliard]

Matteo Bruni  writes:
> @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name )
>          *func_ptr = driver_func;
>      }
> - if (!strcmp(name, "glGetStringi"))
> -
>    return (void *)glGetStringi;

It seems to me you could handle this one through the extension table
instead of special casing it.

[PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)

[Matteo Bruni]

2015-02-10 13:41 GMT+01:00 Alexandre Julliard :
> Matteo Bruni  writes:
> > @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name )
> >          *func_ptr = driver_func;
> >      }
> > - if (!strcmp(name, "glGetStringi"))
> > -
> >    return (void *)glGetStringi;
>
> It seems to me you could handle this one through the extension table
> instead of special casing it.

Right, I can still go through the extension table just fine. It
requires special handling in make_opengl instead but it does look
nicer to me.

Is the attached patch more like what you expected to see?
> --
> Alexandre Julliard
> [e-mail]

[PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)

[Alexandre Julliard]

Matteo Bruni  writes:
> 2015-02-10 13:41 GMT+01:00 Alexandre Julliard :
> > Matteo Bruni  writes:
> > > @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name )
> > >          *func_ptr = driver_func;
> > >      }
> > > - if (!strcmp(name, "glGetStringi"))
> > > -
> > >    return (void *)glGetStringi;
> >
> > It seems to me you could handle this one through the extension table
> > instead of special casing it.
>
> Right, I can still go through the extension table just fine. It
> requires special handling in make_opengl instead but it does look
> nicer to me.
>
> Is the attached patch more like what you expected to see?

Yes, that's better.