Folks,
I've now added support in the patch tracker to enable assigning a reviewer to a patch. If you get assigned a patch, you are expected to either reply with a sign-off, or send a comment to wine-devel (and please CC the patch author).
Initially I'm only going to assign patches to people who have listed themselves as maintainers for the area that the patch modifies.
A further step will be to gather a list of volunteers who are willing to be assigned patches for areas that don't have an active maintainer. I don't know what's the best mechanism for that, I was thinking we could have volunteer entries in MAINTAINERS, from which I would pick someone. I'd like to hear suggestions for other approaches.
Also, currently you don't get a mail telling you that you have been assigned a patch, so you have to watch the patch tracker. I can add that feature if people think it would be useful and not too obnoxious. Please let me know.
Hi,
On Oct 15, 2015, at 8:31 AM, Alexandre Julliard julliard@winehq.org wrote:
Also, currently you don't get a mail telling you that you have been assigned a patch, so you have to watch the patch tracker. I can add that feature if people think it would be useful and not too obnoxious. Please let me know.
Not that I'm going to be responsible for reviewing much, but… I do not regularly watch the patch tracker and don't particularly want to start. If I'm assigned to review a patch, I'd prefer to be directly notified. Thanks.
-Ken
On 15 October 2015 at 17:14, Ken Thomases ken@codeweavers.com wrote:
Not that I'm going to be responsible for reviewing much, but… I do not regularly watch the patch tracker and don't particularly want to start. If I'm assigned to review a patch, I'd prefer to be directly notified. Thanks.
Realistically, I don't think you'd need to look at the tracker much, since generally you'd look at wine-patches and notice anything you're responsible for there. Though if people really want more e-mail, I suppose you could do something along the lines of "This list of patches has had no reply over the last two weeks, and you're responsible for them."