Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

[Jacek Caban]

Please ignore this last patch. It has one more dependency that I didn't
send yet.

On 09/17/12 15:21, Jacek Caban wrote:
> dlls/jscript/jsutils.c |    4 +-
>  dlls/jscript/jsval.h   |  143
> +++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 114 insertions(+), 33 deletions(-)

[PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

[Juan Lang]

Hi Jacek,

+ * that NaN value representation has 52 (almost) free bytes.

You mean bits, yes?

While you're at it,
+ * jsval_t structure is used to represent JavaScript dynamicaly-typed values.

dynamically is spelled with two l's.

Thanks,
--Juan

[PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

[Jacek Caban]

Hi Juan,

On 09/17/12 22:42, Juan Lang wrote:
> Hi Jacek,
> -
> - that NaN value representation has 52 (almost) free bytes.
>
> You mean bits, yes?

Yes, of course.
> While you're at it,
> -
> - jsval_t structure is used to represent JavaScript dynamicaly-typed values.
>
> dynamically is spelled with two l's.

Thanks for catching those. I will fix it while resubmitting after I will
fix exception value propagation.

Thanks,
Jacek