Re: msvcrt: implement _ftol in msvcrt instead of forwarding to ntdll (1/2)

[Piotr Caban]

On 12/13/12 02:57, Austin English wrote:
+ * Based on MSVCRT__ftol in dlls/ntdll/misc.c
+ */
+#if defined(__GNUC__) && defined(__i386__)
+LONGLONG CDECL MSVCRT__ftol(void)
+{

+@ cdecl -ret64 _ftol() MSVCRT__ftol
+@ cdecl -ret64 _ftol2() MSVCRT__ftol

This will not work on 64-bit build or when __GNUC__ is not defined. I 
don't see _ftol function in native 64-bit msvcrt, maybe it should not be 
exported there.

msvcrt: implement _ftol in msvcrt instead of forwarding to ntdll (1/2)

[Austin English]

On Thu, Dec 13, 2012 at 2:04 AM, Piotr Caban  wrote:
> On 12/13/12 02:57, Austin English wrote:
> -
> - Based on MSVCRT__ftol in dlls/ntdll/misc.c
> - */
>
> +#if defined(__GNUC__) && defined(__i386__)
> +LONGLONG CDECL MSVCRT__ftol(void)
> +{
>
> +@ cdecl -ret64 _ftol() MSVCRT__ftol
> +@ cdecl -ret64 _ftol2() MSVCRT__ftol
>
> This will not work on 64-bit build or when __GNUC__ is not defined. I don't
> see _ftol function in native 64-bit msvcrt, maybe it should not be exported
> there.

Yeah, that's what ntdll was doing, I've sent an updated patch.