Ove Kaaven ovehk@ping.uio.no writes:
The logic in this patch is now somewhat revised according to Alexandre's comments. I did not make this configurable, though, thinking that if the user's WM really is too old to support them, then he probably wouldn't mind getting more top-level windows managed anyway...
Top-level windows maybe not, but menus and tooltips with wm decorations are pretty annoying... so I applied it, but without the is_window_managed changes, we will need a better algorithm there.
On 21 Jan 2002, Alexandre Julliard wrote:
Ove Kaaven ovehk@ping.uio.no writes:
The logic in this patch is now somewhat revised according to Alexandre's comments. I did not make this configurable, though, thinking that if the user's WM really is too old to support them, then he probably wouldn't mind getting more top-level windows managed anyway...
Top-level windows maybe not, but menus and tooltips with wm decorations are pretty annoying...
These won't be managed. Notice that my patch only manages popup windows if they are children of the desktop, which I assume neither menus nor tooltips are.
Ove Kaaven ovehk@ping.uio.no writes:
These won't be managed. Notice that my patch only manages popup windows if they are children of the desktop, which I assume neither menus nor tooltips are.
Of course they are. They cannot be children of another window or they would get clipped to the window rectangle.
On 21 Jan 2002, Alexandre Julliard wrote:
Ove Kaaven ovehk@ping.uio.no writes:
These won't be managed. Notice that my patch only manages popup windows if they are children of the desktop, which I assume neither menus nor tooltips are.
Of course they are. They cannot be children of another window or they would get clipped to the window rectangle.
This is incorrect, but I guess my code was also. For example, dialog boxes are popup windows parented by their owner. They are not clipped to their parent, but dialogs should probably also be managed. Hmm...
Ove Kaaven ovehk@ping.uio.no writes:
This is incorrect, but I guess my code was also. For example, dialog boxes are popup windows parented by their owner. They are not clipped to their parent, but dialogs should probably also be managed. Hmm...
You seem to confuse parent and owner. win->parent is always the real parent in the window hierarchy, no matter whether the window is owned or not. It will be the desktop for all top-level windows, including menus, popup dialogs, etc.
Of course to make things simple the 'parent' parameter of CreateWindow sometimes means parent and sometimes owner. But in the window data structure they are two separate fields. In any case I don't think we can use the owner to distinguish managed/non-managed either.
-
Alexandre Julliard -
Ove Kaaven