Hi All,
I'm pleased to announce that after a lot of work lately I've pretty much completed the graphics for the icons for shell32, user32 and the programs all sizes and screen depths:
http://www.airwebreathe.org.uk/wine-icon/
There are a few minor things left to do:
* comctl32: Finish and submit - only idb_std_small.bmp needs to be upgraded. Only idb_std_small.bmp is 32-bit in XP, and Vista * comdlg32: Convert bitmaps to 8-bit. Maybe rework comdlg32 so that the graphics are stored as a icons not bitmaps for so that different colour depths can be handled elegantly. What does windows do? * credui: Test on a low bit-depth platform, and submit. * cryptui: Redo emblems on certwarning.bmp, certerror.bmp, and convert bitmaps into icons for so that different colour depths can be handled elegantly. * winecfg: new transparent bitmap won't work without xrender on a 32-bpp screen. Think again. * wine: image lists still strip the alpha channel. talk to thunderbird about 32-bit DDBs * control, dxdiag, iexplore, winecfg: These programs currently do not have an icon, and although my patches add the icon to the src dir, further patches will be needed to add the icon to the progam's resources, and display them in the app windows.
These things are all relatively minor, and I think at this stage it would be good to merge as soon as possible. The only major issue that remains is that there are 3 icons from Gnome that need to be relicensed as LGPL for our use. I've e-mailed the gnome artists mailing list, so hopefully we'll hear back from them soon.
Once this is done I'm suggesting we merge the icons for shell32, user32 and the programs. If you're interested you can try them right now at the public-beta-2 branch of my gitorious repo: http://gitorious.org/wine-tango/wine-tango/commits/public-beta-2
My final question is about what to do with my source artwork. The artwork has been collected from a variety of sources. Some is SVGs, some gimp .xcf.bz2s, and some plain PNGs. I guess these shouldn't go into the wine source repo, but does anyone have any bright ideas where these files *should* go? They'll need to be published in case the icons ever need to be changed in any way.
Any thoughts?
Best Regards Joel
Joel Holdsworth joel@airwebreathe.org.uk writes:
My final question is about what to do with my source artwork. The artwork has been collected from a variety of sources. Some is SVGs, some gimp .xcf.bz2s, and some plain PNGs. I guess these shouldn't go into the wine source repo, but does anyone have any bright ideas where these files *should* go? They'll need to be published in case the icons ever need to be changed in any way.
Ideally they would all be SVG, we already have the infrastructure for that, and for regenerating the icons from it. Though I don't know how that would work for low bit depths, it probably needs some makefile work.
On Thu, 2009-12-31 at 11:34 +0100, Alexandre Julliard wrote:
Joel Holdsworth joel@airwebreathe.org.uk writes:
My final question is about what to do with my source artwork. The artwork has been collected from a variety of sources. Some is SVGs, some gimp .xcf.bz2s, and some plain PNGs. I guess these shouldn't go into the wine source repo, but does anyone have any bright ideas where these files *should* go? They'll need to be published in case the icons ever need to be changed in any way.
Ideally they would all be SVG, we already have the infrastructure for that, and for regenerating the icons from it. Though I don't know how that would work for low bit depths, it probably needs some makefile work.
Yes - I agree. However, I don't think it can work. It's really only the 32-bpp and 32x32 and 48x48 that can be generated from vector. The rest have all had at least some pixel work done. Some are completely done in raster. This is a reality of making icons; like hinting a font there's a lot of manual intervention at small sizes and low depths. That's one of the reasons it's taken so long to make the set.
To make matters worse, a few of the icons were *acquired* as pngs or xcf.bz2s, which means I have no svg to begin with. It's all a very mixed bag.
Complicating things further, I've found two bugs in icotool, which means that I have to run the compiled icons through my own icon tweaker program that fixes up the problems with the file (I've contacted the original author about the problem).
For this reason I think the best thing would be for me to tidy up my project directory and upload it as a tarball somewhere. There's enough source material there so that someone could come and adjust the icons - even it's not as elegant as having it tied into the build process.
Another question: When the time comes, what would be the best way to submit the icons? I have 36 patches each of which is going to be many kilobytes. Will the wine-patches mailing list take such large attachments? Would it be easier to send you a git pull request from my gitorious repo?
Joel Holdsworth schrieb:
For this reason I think the best thing would be for me to tidy up my project directory and upload it as a tarball somewhere. There's enough source material there so that someone could come and adjust the icons - even it's not as elegant as having it tied into the build process.
ftp://ftp.winehq.org/pub/ would be a good solution.
Another question: When the time comes, what would be the best way to submit the icons? I have 36 patches each of which is going to be many kilobytes. Will the wine-patches mailing list take such large attachments? Would it be easier to send you a git pull request from my gitorious repo?
At wineconf2009 we learned that there is something like a "patch-hole" in may, so that there are very less patches and it would be the best time to submit big patchsets :) But maybe we are already in codefreeze till then, i dont know.
-
Alexandre Julliard -
André Hentschel -
Joel Holdsworth