Re: [6/6] oleaut32/tests: Add more tests for typelib data.

[Andrew Eikum]

On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote:
> +{
> - "a",
> - "{00000000-0000-0000-0000-000000000000}",
> - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> - /*#vtbl*/ 0, /*#func*/ 0
>
> +},

...
> +{
> - "c",
> - "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}",
> - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> - /*#vtbl*/ 0, /*#func*/ 0
>
> +},

These two tests fail on my Win7 VM:

typelib.c:4378: Interface a
typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
typelib.c:4378: Interface _a
typelib.c:4378: Interface aa
typelib.c:4378: Interface _b
typelib.c:4378: Interface bb
typelib.c:4378: Interface c
typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
typelib.c:4378: Interface _c

I get the same failures when running the tests on Wine.

Unlike the testbot, everything else passes on my VM.

Andrew

[6/6] oleaut32/tests: Add more tests for typelib data.

[Dmitry Timoshkov]

Andrew Eikum  wrote:
> On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote:
> > +{
> > - "a",
> > - "{00000000-0000-0000-0000-000000000000}",
> > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > - /*#vtbl*/ 0, /*#func*/ 0
> >
> > +},
>
> ...
> > +{
> > - "c",
> > - "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}",
> > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > - /*#vtbl*/ 0, /*#func*/ 0
> >
> > +},
>
> These two tests fail on my Win7 VM:
>
> typelib.c:4378: Interface a
> typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> typelib.c:4378: Interface _a
> typelib.c:4378: Interface aa
> typelib.c:4378: Interface _b
> typelib.c:4378: Interface bb
> typelib.c:4378: Interface c
> typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> typelib.c:4378: Interface _c
>
> I get the same failures when running the tests on Wine.
>
> Unlike the testbot, everything else passes on my VM.

How do you build the tests? Just with 'make crosstest'? If yes, did you
make sure that widl is rebuilt?

[6/6] oleaut32/tests: Add more tests for typelib data.

[Andrew Eikum]

On Mon, Oct 05, 2015 at 11:46:59PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum  wrote:
> > On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote:
> > > +{
> > > - "a",
> > > - "{00000000-0000-0000-0000-000000000000}",
> > > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > > - /*#vtbl*/ 0, /*#func*/ 0
> > >
> > > +},
> >
> > ...
> > > +{
> > > - "c",
> > > - "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}",
> > > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > > - /*#vtbl*/ 0, /*#func*/ 0
> > >
> > > +},
> >
> > These two tests fail on my Win7 VM:
> >
> > typelib.c:4378: Interface a
> > typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> > typelib.c:4378: Interface _a
> > typelib.c:4378: Interface aa
> > typelib.c:4378: Interface _b
> > typelib.c:4378: Interface bb
> > typelib.c:4378: Interface c
> > typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> > typelib.c:4378: Interface _c
> >
> > I get the same failures when running the tests on Wine.
> >
> > Unlike the testbot, everything else passes on my VM.
>
> How do you build the tests? Just with 'make crosstest'? If yes, did you
> make sure that widl is rebuilt?

After applying your patches, I did a git-clean and built from scratch.
I'm just using an in-tree 32-bit build, haven't tried 64-bit.

Andrew

[6/6] oleaut32/tests: Add more tests for typelib data.

[Dmitry Timoshkov]

Andrew Eikum  wrote:
> > +{
> > - "a",
> > - "{00000000-0000-0000-0000-000000000000}",
> > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > - /*#vtbl*/ 0, /*#func*/ 0
> >
> > +},
>
> ...
> > +{
> > - "c",
> > - "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}",
> > - /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4,
> > - /*#vtbl*/ 0, /*#func*/ 0
> >
> > +},
>
> These two tests fail on my Win7 VM:
>
> typelib.c:4378: Interface a
> typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> typelib.c:4378: Interface _a
> typelib.c:4378: Interface aa
> typelib.c:4378: Interface _b
> typelib.c:4378: Interface bb
> typelib.c:4378: Interface c
> typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0
> typelib.c:4378: Interface _c
>
> I get the same failures when running the tests on Wine.
>
> Unlike the testbot, everything else passes on my VM.

Thanks for pointing this out Andrew, I can reproduce this now, and testbot
confirms that it's another difference between midl and widl: midl sets
cbSizeInstance for TKIND_ALIAS to 4 while widl stores 0 for this type.