Re: shell32: fix SHFileOperation copying to an empty file list

[James Hawkins]

On Sat, May 31, 2008 at 8:10 PM, Vincent Povirk
 wrote:
> On Windows, copying files to an empty file list copies each file to
> the working directory, truncating each filename to 8.3 format. See bug
> 13394.
>
> I'm not very happy about the way I implemented this (a special loop
> just for the weird case), but it doesn't seem possible to use the
> current copy_files loop. This is too different from what the function
> does in every other possible situation.

I'm not either.  There's a very simple way to implement this.  Also,
you need to add tests for the FO_MOVE action as well.

@@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void)
     DeleteFileA("test3.txt");
     DeleteFileA("test_5.txt");
     DeleteFileA("one.txt");
+    DeleteFileA("filename.tex");
     DeleteFileA("test4.txt\test1.txt");
     DeleteFileA("test4.txt\test2.txt");
     DeleteFileA("test4.txt\test3.txt");

typo, and why didn't you stick with the convention used for all the
other test files (.txt, not .text)?