ddraw bug

[hatky]

I just tried running Laser Squad Nemesis and got a
crash:

Unhandled exception: page fault on read access to
0x00000004 in 32-bit code (0x40bb8ad3).
In 32-bit mode.
0x40bb8ad3 (HAL_DirectDrawSurface_Construct+0xd3
[hal.c:127] in ddraw.dll.so): cmpb    
$0x0,0x4(%eax)
127             if (!(dd_gbl->dwFlags &
DDRAWI_MODECHANGED)) {
Wine-dbg>
wine_dbg_cmd: Ctrl-C
Ctrl-C: stopping debuggee
[hatky@n Laser Squad Nemesis]$ WineDbg terminated on
pid 8

I just guess it means the code need to check for null
or something...

Thought that would be of interest (since there is a
lot of display work for games lately),
Hatky.

__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com

[Raphaël Junqueira]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
> I just tried running Laser Squad Nemesis and got a
> crash:
>
> Unhandled exception: page fault on read access to
> 0x00000004 in 32-bit code (0x40bb8ad3).
> In 32-bit mode.
> 0x40bb8ad3 (HAL_DirectDrawSurface_Construct+0xd3
> [hal.c:127] in ddraw.dll.so): cmpb
> $0x0,0x4(%eax)
> 127             if (!(dd_gbl->dwFlags &
> DDRAWI_MODECHANGED)) {
> Wine-dbg>
> wine_dbg_cmd: Ctrl-C
> Ctrl-C: stopping debuggee
> [hatky@n Laser Squad Nemesis]$ WineDbg terminated on
> pid 8
>
> I just guess it means the code need to check for null
> or something...

well, for what i know of that code 'dd_gbl' should never be null.
If it's NULL you may have a huge integrity problem in ddraw ;(

Have anyone the same behavior ?
> Thought that would be of interest (since there is a
> lot of display work for games lately),
> Hatky.

Regards,
Raphael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+4hDPp7NA3AmQTU4RAgomAJ4gE3RizPzNGWVJvRCM3NCVv2wAFgCfROhh
Vj85waS4/SE3PfVXGax1k8w=
=tIvW
-----END PGP SIGNATURE-----

[Lionel Ulmer]

> well, for what i know of that code 'dd_gbl' should never be null.
> If it's NULL you may have a huge integrity problem in ddraw ;(
>
> Have anyone the same behavior ?

I never saw this. But well, a '+ddraw' trace could only help us debug the
issue (because just a GDB backtrace is usually not enough to understand when
and where the problem occured).

So could you (nor Raphaël :-) ) send to the list if not too big or to me in
private a +ddraw log up to the point where the game crashes.

Lionel

[hatky]

> So could you (nor Rapha� :-) ) send to the list if
> not too big or to me in
> private a +ddraw log up to the point where the game
> crashes.

Since my mail was rejected (over 60k, good to know the
limit) I opened this as a bug:
http://bugs.winehq.org/show_bug.cgi?id=1514

I put a Tropico2 +ddraw trace since I know this game
has worked before the last to commit
bursts....(regression bug)

__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com

[Raphaël Junqueira]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
> > So could you (nor Rapha� :-) ) send to the list if
> > not too big or to me in
> > private a +ddraw log up to the point where the game
> > crashes.
>
> Since my mail was rejected (over 60k, good to know the
> limit) I opened this as a bug:
> http://bugs.winehq.org/show_bug.cgi?id=1514
>
> I put a Tropico2 +ddraw trace since I know this game
> has worked before the last to commit
> bursts....(regression bug)

looking at traces,
all seems correct and valid.

And only you have the same problem
have you a clean install ?

Regards,
Raphael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+4mP5p7NA3AmQTU4RAp+6AJ4ztqMnPfYPZoWxFLi54JBiJwMN1gCfdknp
Aa4Xt1wbEarBHvN42lzkgsg=
=Whtb
-----END PGP SIGNATURE-----

[hatky]

> And only you have the same problem

Any one have on of the games I mentioned??? (these
games aren't particlerly common)
> have you a clean install ?

I did 
make clean
./configure
./tools/install

I did not change the confige or anything from the prev
installtion, but this is what I do every cvs update
usualy without clean and configure but this time I had
to becouse of some d3d compile problems...

I there a point in wasteing another 2-3h for a full
fresh install?

__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com

[Lionel Ulmer]

> Any one have on of the games I mentioned??? (these
> games aren't particlerly common)

Well, seeing where you crash and the +ddraw trace just before, it's a pretty
common set of consecutive DDraw calls common to many games.

Did you try more games or only these two ?
> I did not change the confige or anything from the prev
> installtion, but this is what I do every cvs update
> usualy without clean and configure but this time I had
> to becouse of some d3d compile problems...

Well, considering that neither me nor Raphael has never seen this issue, I
think that you will have to debug it yourself... Or try to find a demo
version of these games showing the issue for us to be able to debug it :-)

If you want to debug it yourself, break on 'HAL_DirectDraw_Construct', see
that 'This->local.lpGbl' is correctly initialized and then put a watchpoint
on the lpGbl variable to see when it goes back to being NULL.

Lionel

[hatky]

I don't get this, I did it all again
make clean
./configure
./tools/wineinstall

and now things seem to work....

10x for all the help,
Hatky.

__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com