Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

[James Hawkins]

On Nov 21, 2007 5:15 PM, Roman Mamedov  wrote:
> Hello.
>
> Presently, if an ATI card uses open-source DRI drivers from the Mesa
> project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to
> Windows applications as being some generic nVIDIA model, based on D3D
> capabilities of the card.
>
> This patch adds detection of the used ATI video card, based on Mesa DRI
> module name, which is returned by drivers in GL Renderer string. In my
> opinion, returning even an approximate ATI card model should be better,
> than the present condition, disguising the ATI card as some equally
> generic model from nVIDIA. Also, the patch adds detection of VENDOR_MESA
> from GL Renderer string, as Mesa DRI drivers may have various things as
> GL Vendor, but the GL Renderer name always contains the string "Mesa".
> This patch resolves the bug #7267, "Lineage 2 complains about outdated
> NVIDIA drivers using ATI card with Mesa drivers" -
> http://bugs.winehq.org/show_bug.cgi?id=7267 .

If you send in a fixed patch, you need to add some variation of 'try
X' in the subject, where X is the number of tries you're on.  On top
of this, you need to say in the body what you've changed between
submissions.

WineD3D: Implement detection of ATI cards with Mesa DRI drivers

[Roman Mamedov]

James Hawkins wrote:
> > If you send in a fixed patch, you need to add some variation of 'try
> > X' in the subject, where X is the number of tries you're on.  On top
> > of this, you need to say in the body what you've changed between
> > submissions.

Thank you. I think I did mention the change in the body (just before the 
patch itself), maybe not very prominently, though. Sorry for the 
mistakes, it is the first time I submit a patch to Wine.