I'm not sure how complete this new listview code is supposed to be, but I've noticed the more recent commits seem to just be code reorg and cleanups as opposed to functionality stuff, so I might as well say it...
I've noticed a lot of regression problems since these patches started coming in.. for the last few days Listviews have been pretty much totally broken in most of the applications I frequently run under WINE - expecially IDA Pro (the Windows GUI version), which exibits at least two problems... the Names window doesn't show the description column text, and neither the Names or Strings window listboxes are clickable.. usually you'd double-click to jump to a position, but that is no longer working.
Dimitrie, if these are known and it's still a work-in-progress, ignore me :) But just in case these breakages are related to the removal of some workaround or other, I thought I'd drop an email off.
- Ender
[IDA Evaluation should be requestable from somewhere on www.datarescue.com/idabase/, otherwise I can try tracing and working up a testcase if this actually IS a real bug, and not just an incomplete patchset]
On Wed, 2 Oct 2002, Alexandre Julliard wrote:
Date: Wed, 2 Oct 2002 18:53:04 -0500 From: Alexandre Julliard julliard@wine.codeweavers.com Reply-To: wine-devel@winehq.com To: wine-cvs@winehq.com Subject: wine/dlls/comctl32 listview.c
ChangeSet ID: 5615 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard@wine.codeweavers.com 2002/10/02 18:53:04
Modified files: dlls/comctl32 : listview.c
Log message: Dimitrie O. Paun dpaun@rogers.com
- Reorganize DrawItem.
- Unify text attribute selection between Draw{Sub,}Item.
- Usual cleanups, and simplifications.
Patch: http://cvs.winehq.com/patch.py?id=5615
Old revision New revision Changes Path 1.162 1.163 +115 -162 wine/dlls/comctl32/listview.c
On October 2, 2002 10:39 pm, Ender wrote:
Dimitrie, if these are known and it's still a work-in-progress, ignore me :) But just in case these breakages are related to the removal of some workaround or other, I thought I'd drop an email off.
Thank you for the bug report. There is some breakage, I am aware of that. Unfortunately, it is unavoidable given the big changes that the listview went through lately.
Now, if you can provide test cases, I'll be happy to look into fixing them.
Just FYI, apparantly the official IDA site won't allow personal downloads of the demo. Thankfully the actual lead programmer had a link on his personal website :)
Link: ftp://ftp.po.cs.msu.su/pub/ida/demo421.zip
Steps to reproduce: - Disassemble a new file.. it's a demo so pick some simple windows executable like Notepad :) - After disassembly is finished or at least well started, open the 'Strings' and 'Names' window from the View -> Open Subview menu.
This is a pretty complex test case, but I've had a busy day with no time to try and replicate the problem in my own code :)
Neither of these bugs were in Wine a week or so ago, before the listview rewrite.
Cheers, Ender
On Thu, 3 Oct 2002, Dimitrie O. Paun wrote:
Date: Thu, 3 Oct 2002 00:41:28 -0400 From: Dimitrie O. Paun dpaun@rogers.com To: Ender winedev@admdev.com, wine-devel@winehq.com Subject: Re: wine/dlls/comctl32 listview.c
On October 2, 2002 10:39 pm, Ender wrote:
Dimitrie, if these are known and it's still a work-in-progress, ignore me :) But just in case these breakages are related to the removal of some workaround or other, I thought I'd drop an email off.
Thank you for the bug report. There is some breakage, I am aware of that. Unfortunately, it is unavoidable given the big changes that the listview went through lately.
Now, if you can provide test cases, I'll be happy to look into fixing them.
-- Dimi.
On October 2, 2002 10:39 pm, Ender wrote:
expecially IDA Pro (the Windows GUI version), which exibits at least two problems... the Names window doesn't show the description column text, and neither the Names or Strings window listboxes are clickable.. usually you'd double-click to jump to a position, but that is no longer working.
Ender, can you please try again (with the latest S-series patches), and tell me the status of this? I would like to know if you still have any problems, a lot of changes went in lately.
On October 2, 2002 10:39 pm, Ender wrote:
coming in.. for the last few days Listviews have been pretty much totally broken in most of the applications I frequently run under WINE - expecially IDA Pro (the Windows GUI version), which exibits at least two problems... the Names window doesn't show the description column text, and neither the Names or Strings window listboxes are clickable.. usually you'd double-click to jump to a position, but that is no longer working.
In fact, I just tried it now, and it works just fine. The only problem I have in the "Names" or "String" window, is that the subitems are drawn black-on-white when selected... Is this supposed to be this way? Any other problems? Speak now, or I'll declare listview perfect! :)
-
Dimitrie O. Paun -
Ender