Alexander Dorofeyev wrote:
dlls/ddraw/device.c | 24 ++++++++++++++---------- 1 files changed, 14 insertions(+), 10 deletions(-)
What is this patch fixing? Do you have tests? Do you have a bug # showing the problem? Please explain why parts of the code needs to be protected?
Vitaliy.
Vitaliy Margolen wrote:
Alexander Dorofeyev wrote:
dlls/ddraw/device.c | 24 ++++++++++++++---------- 1 files changed, 14 insertions(+), 10 deletions(-)
What is this patch fixing? Do you have tests? Do you have a bug # showing the problem? Please explain why parts of the code needs to be protected?
It is fixing an oversight on my part, when I moved these chunks of code few days ago to fix a bug. All ddraw code holds the lock for thread safety, except stubs.
Alexander Dorofeyev wrote:
Vitaliy Margolen wrote:
Alexander Dorofeyev wrote:
dlls/ddraw/device.c | 24 ++++++++++++++---------- 1 files changed, 14 insertions(+), 10 deletions(-)
What is this patch fixing? Do you have tests? Do you have a bug # showing the problem? Please explain why parts of the code needs to be protected?
It is fixing an oversight on my part, when I moved these chunks of code few days ago to fix a bug. All ddraw code holds the lock for thread safety, except stubs.
Ok sounds good and I see what you are fixing.
Vitaliy.
-
Alexander Dorofeyev -
Vitaliy Margolen