Re: mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in about protocol.

[Paul Vriens]

Jacek Caban wrote:
> dlls/mshtml/protocol.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Hi Jacek,

return E_NOTIMPL;
+    case QUERY_USES_HISTORYFOLDER:
+        FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n");
      default:
          return E_FAIL;
      }

shouldn't there be a "return E_NOTIMPL" after the FIXME as we do with the others?

mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in about protocol.

[Jacek Caban]

Hi Paul,

Paul Vriens wrote:
> Hi Jacek,
>      return E_NOTIMPL;
> - case QUERY_USES_HISTORYFOLDER:
> -
>    FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n");
> default:
>        return E_FAIL;
>    }
>
> shouldn't there be a "return E_NOTIMPL" after the FIXME as we do with 
> the others?

It doesn't really matter IMO, so I've made the patch no-op. This way 
Wine will behave like IE6 until we will have proper IE7 implementation.

Jacek

mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in aboutprotocol.

[Dmitry Timoshkov]

"Jacek Caban"  wrote:
> >      return E_NOTIMPL;
> > - case QUERY_USES_HISTORYFOLDER:
> > -
> >    FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n");
> > default:
> >        return E_FAIL;
> >    }
> >
> > shouldn't there be a "return E_NOTIMPL" after the FIXME as we do with 
> > the others?
>
> It doesn't really matter IMO, so I've made the patch no-op. This way 
> Wine will behave like IE6 until we will have proper IE7 implementation.

Then please add the explicit /* fall through */ comment indicating that
the behaviour is intentional, and not just an oversight.