Re: (resend) [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by TranslateBitmapBits

[Hans Leidekker]

On Thu, 2010-10-21 at 17:52 +0200, Tomasz Michno wrote:

Please mark your patches with something like (try X) and comment on
the changes you made in the same e-mail. Use (resend) when you resend
a patch without making any changes.
> +/* defines copied from lcms.h:
> - */
>
> +#define INTENT_PERCEPTUAL                 0
> +#define INTENT_RELATIVE_COLORIMETRIC      1
> +#define INTENT_SATURATION                 2
> +#define INTENT_ABSOLUTE_COLORIMETRIC      3

These should be added to icm.h. I'll send a patch.
> - ret=pTranslateBitmapBits(transform, (void*)bitmapBits,
> - ok( ret, "BGR: TranslateBitmapBits() succeeded (%d)\n",

There's no need to cast to void *. The sense of that error message is
wrong. It's displayed when the condition evaluates to false, so it
should be 'failed'. And it happens to fail on Windows:

transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87)