Re: [PATCH] d3dx9_36: Supplying a AnimationController isn't an error

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-10-26 um 09:56 schrieb Alistair Leslie-Hughes:
> - if (anim_controller) {
> -
>    *anim_controller = NULL;
> -
> -
>    FIXME("Animation controller creation not implemented\n");
> - }

Do you have an easy way to write this FIXME only if the file has an
AnimationSet node? Or maybe even keep returning E_NOTIMPL if the
output should be non-NULL?

Also the style doesn't follow the general d3d style ('{' goes in its
own line).
> -
>    ok(frame_hier->Name == NULL, "Expected NULL, got '%s'\n", frame_hier->Name);
> -
>    D3DXMatrixIdentity(&transform);
> -
>    check_matrix(&frame_hier->TransformationMatrix, &transform);

It looks like these are the same tests as the ones right above the
call. I'd skip them and only have controller-related test.

A test input that should result in a non-NULL controller would be
helpful as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWLfs5AAoJEN0/YqbEcdMwAM4P/1NSVVxBt3HGXPjqeF1Z6o93
6qV+C/MJB/82evJpf34zARYBXd6WzdeL+YbUl9K9G2iDZ/KLKf5l5opMnMD7cL1h
841dtZQu4IA3mJtwSY345+7YLcRV0qfYEHwFxvlO7JVqk9UIcsaE/kp+7tUvrFHD
V5IIKSQrN6IhcGJDC51XIwcL2xxhgyco+5UOus6m6kKDBr+mpTxCVYpMOA4O/MjB
fXoZl3S4SWkmJQwh8l9azycmRQ3y6xtQA8EksOWXxLv1lPhtdeb2LtP5w14vM4dC
3z3rC0NzDIAC+a5uNlhRbH8jb6SIlcdgInKaCaTSo9s8944eagaEh/ED2K4Q47Ub
QaTz7JITa55ZnPuhgzms+Y3W8yW4QaEjgAo3L7/C91bVdBvwkBW0NBxIaMEgUU0M
r+ZhjZPA2XsJ700k3SpB3BFHyFVT/qOtYLceNcE3d+8uJlmiqCu5xj6N4hojv1g2
gz8Map0/30mtA4b6IWD/kmnETYIZYYz28bzo8p56q25XFMGT1huArqW3JAlEe5Ic
cKCUiNp3Visnzk9XJvmuW8wGVPk2Pta6UzdMCRiCF67Elb8Id8qqZc+GKsOm/FLV
kSCvrXMaodeWqjnnyQIyI1QBo7Hoc4Q/V0iKiIVsPqvuY1wbmyTeVBdhqc+yKFw3
0llsQI07wd6TIWXgklAM
=Xuvx
-----END PGP SIGNATURE-----