RE: Simplify dlls/comctl32/nativefont.c

[ricardo filipe]

are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ...

----------------------------------------
> Date: Sat, 27 Dec 2008 08:57:44 +0100
> From: [e-mail]
> To: [e-mail]
> Subject: Simplify dlls/comctl32/nativefont.c
>
> ChangeLog:
> Simplify NATIVEFONT_Create.
> Index: dlls/comctl32/nativefont.c
>
> RCS file: /home/wine/wine/dlls/comctl32/nativefont.c,v
> retrieving revision 1.29
> diff -u -3 -p -r1.29 nativefont.c
> --- dlls/comctl32/nativefont.c 24 Oct 2008 13:13:47 -0000 1.29
> +++ dlls/comctl32/nativefont.c 27 Dec 2008 07:57:10 -0000
> @@ -47,7 +47,7 @@ typedef struct
> #define NATIVEFONT_GetInfoPtr(hwnd) ((NATIVEFONT_INFO *)GetWindowLongPtrW (hwnd, 0))
>
> static LRESULT
> -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam)
> +NATIVEFONT_Create (HWND hwnd)
> {
> NATIVEFONT_INFO *infoPtr;
>
> @@ -85,7 +85,7 @@ NATIVEFONT_WindowProc (HWND hwnd, UINT u
> switch (uMsg)
> {
> case WM_CREATE:
> - return NATIVEFONT_Create (hwnd, wParam, lParam);
> - return NATIVEFONT_Create (hwnd);
>
> case WM_DESTROY:
> return NATIVEFONT_Destroy (infoPtr);

_________________________________________________________________
Show them the way! Add maps and directions to your party invites. 
http://www.microsoft.com/windows/windowslive/events.aspx

Simplify dlls/comctl32/nativefont.c

[Nikolay Sivov]

ricardo filipe wrote:
> are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ...
> > Date: Sat, 27 Dec 2008 08:57:44 +0100
> > From: [e-mail]
> > To: [e-mail]
> > Subject: Simplify dlls/comctl32/nativefont.c
> >
> > ChangeLog:
> > Simplify NATIVEFONT_Create.
> > Index: dlls/comctl32/nativefont.c
> >
> > RCS file: /home/wine/wine/dlls/comctl32/nativefont.c,v
> > retrieving revision 1.29
> > diff -u -3 -p -r1.29 nativefont.c
> > --- dlls/comctl32/nativefont.c 24 Oct 2008 13:13:47 -0000 1.29
> > +++ dlls/comctl32/nativefont.c 27 Dec 2008 07:57:10 -0000
> > @@ -47,7 +47,7 @@ typedef struct
> > #define NATIVEFONT_GetInfoPtr(hwnd) ((NATIVEFONT_INFO *)GetWindowLongPtrW (hwnd, 0))
> >
> > static LRESULT
> > -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam)
> > +NATIVEFONT_Create (HWND hwnd)
> > {
> > NATIVEFONT_INFO *infoPtr;
> >
> > @@ -85,7 +85,7 @@ NATIVEFONT_WindowProc (HWND hwnd, UINT u
> > switch (uMsg)
> > {
> > case WM_CREATE:
> > - return NATIVEFONT_Create (hwnd, wParam, lParam);
> > - return NATIVEFONT_Create (hwnd);
> >
> > case WM_DESTROY:
> > return NATIVEFONT_Destroy (infoPtr);
>
> Show them the way! Add maps and directions to your party invites. 
> http://www.microsoft.com/windows/windowslive/events.aspx

It isn't exported.

Simplify dlls/comctl32/nativefont.c

[Gerald Pfeifer]

On Sat, 27 Dec 2008, ricardo filipe wrote:
> are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ...

Yes, I am.  Looking at the patch...
> > static LRESULT
> > -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam)
> > +NATIVEFONT_Create (HWND hwnd)

...you'll notice that this function is static and thus cannot be
invoked by any external caller.  I have explicitly excluded functions
with external linkage or callback functions from such simplifications.

Gerald