[wined3d] regression

[Oliver Stieber]

Following this patch http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d SegV's
every time the dll is loaded.

___________________________________________________________ 
How much free photo storage do you get? Store your holiday 
snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

[Robert Shearman]

Oliver Stieber wrote:
> Following this patch http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d SegV's
> every time the dll is loaded.

One bug is that GetModuleFileName is called with a buffer size of 
MAX_PATH, yet buffer is only 64 chars big.

[Oliver Stieber]

--- Robert Shearman  wrote:
> Oliver Stieber wrote:
> > Following this patch http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d
>
> SegV's
> > every time the dll is loaded.
>
> One bug is that GetModuleFileName is called with a buffer size of 
> MAX_PATH, yet buffer is only 64 chars big.

Yep, that was it. I've just sent in a patch to correct the issue.
> -- 
> Rob Shearman

___________________________________________________________ 
How much free photo storage do you get? Store your holiday 
snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

[Raphael]

On Monday 25 July 2005 19:47, Robert Shearman wrote:
> Oliver Stieber wrote:
> > Following this patch
> > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d
> > SegV's every time the dll is loaded.
>
> One bug is that GetModuleFileName is called with a buffer size of
> MAX_PATH, yet buffer is only 64 chars big.

You are right i'm too stupid :(
(taking my brown paper bag...)

But i'm interested to see how Oliver have the crash each times it use wined3d 
(for me it doesn't crash)

Regards,
Raphael

[Oliver Stieber]

--- Raphael  wrote:
> On Monday 25 July 2005 19:47, Robert Shearman wrote:
> > Oliver Stieber wrote:
> > > Following this patch
> > > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d
> > > SegV's every time the dll is loaded.
> >
> > One bug is that GetModuleFileName is called with a buffer size of
> > MAX_PATH, yet buffer is only 64 chars big.
>
> You are right i'm too stupid :(
> (taking my brown paper bag...)
>
> But i'm interested to see how Oliver have the crash each times it use wined3d 
> (for me it doesn't crash)

I get a segment fault after returning from the function, all I can assume is that the stack is
getting corrupted by the buffer overrun, maybe mp path length is >64 and yours = <64?
> Regards,
> Raphael

___________________________________________________________ 
How much free photo storage do you get? Store your holiday 
snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com