What's the right way to implement _wtoi_l?

[Alex Henrie]

Dear Wine developers,

Bug 24389 documents an application crash due to the unimplemented
function msvcr90._wtoi_l. I have been looking into how to resolve this
problem. I see three workable options:

1. Implement msvcr90._wtoi_l by copying the code from ntdll._wtoi to
msvcrt, ignoring the locale parameter for now.

2. Forward msvcr90._wtoi_l to ntdll._wtoi via msvcr90.spec, ignoring
the locale parameter for now.

3. Implement msvcr90._wtoi_l as a stub function in msvcrt that always returns 0.

Any of these options would fix bug 24389. Which one should I work on?

-Alex

[Austin English]

On Sun, Jul 22, 2012 at 11:07 PM, Alex Henrie  wrote:
> Dear Wine developers,
>
> Bug 24389 documents an application crash due to the unimplemented
> function msvcr90._wtoi_l. I have been looking into how to resolve this
> problem. I see three workable options:
> - Implement msvcr90._wtoi_l by copying the code from ntdll._wtoi to
>
> msvcrt, ignoring the locale parameter for now.
> - Forward msvcr90._wtoi_l to ntdll._wtoi via msvcr90.spec, ignoring
>
> the locale parameter for now.
> - Implement msvcr90._wtoi_l as a stub function in msvcrt that always returns 0.
>
> Any of these options would fix bug 24389. Which one should I work on?
>
> -Alex

Judging by similar recent commits
(http://source.winehq.org/git/wine.git/commitdiff/f320f6cf4843eab3d22b6067480...),
1 seems to be the way to go.

[Alex Henrie]

2012/7/23 Austin English :
> Judging by similar recent commits
> (http://source.winehq.org/git/wine.git/commitdiff/f320f6cf4843eab3d22b6067480...),
> 1 seems to be the way to go.

Thanks for the answer. What makes me uneasy about this approach is
that if I want to duplicate the tests for wtoi, there are a LOT of
them:
http://source.winehq.org/git/wine.git/blob/7b89de9e481cf8cca264dc48c444f2c33...

Could I just copy the wtoi code and not the tests? Also, out of
curiosity, why can't you call a function in ntdll.dll from msvcrt.dll?

-Alex

[André Hentschel]

Am 24.07.2012 06:58, schrieb Alex Henrie:
> 2012/7/23 Austin English :
> > Judging by similar recent commits
> > (http://source.winehq.org/git/wine.git/commitdiff/f320f6cf4843eab3d22b6067480...),
> > 1 seems to be the way to go.
>
> Thanks for the answer. What makes me uneasy about this approach is
> that if I want to duplicate the tests for wtoi, there are a LOT of
> them:
> http://source.winehq.org/git/wine.git/blob/7b89de9e481cf8cca264dc48c444f2c33...
>
> Could I just copy the wtoi code and not the tests? Also, out of
> curiosity, why can't you call a function in ntdll.dll from msvcrt.dll?

FWIW, i choosed that way because the implementation differed already in the function prototype.