Re: [patch] Support NULL puLen in VerQueryValue

[Andrew Nguyen]

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote:
> I couldn't find any documentation saying that this must be supported,
> but running google code search on VerQueryValue.*NULL found some uses.
>
> Cheers,
> Rafael

You should write some tests to examine the behavior of VerQueryValue
with NULL puLen.

[patch] Support NULL puLen in VerQueryValue

[Rafael Ávila de Espíndola]

> You should write some tests to examine the behavior of VerQueryValue
> with NULL puLen.

I just found out that wine has a test for it, but it has been commented out:

if (0)
     {
     /* this test crashes on WinNT4
      */
     boolret = VerQueryValueA( pVersionInfo, backslash, (LPVOID 
*)&pFixedVersionInfo, 0);
     ok (boolret, "VerQueryValue failed: GetLastError = %u\n", 
GetLastError());
     }

Cheers,
Rafael

[patch] Support NULL puLen in VerQueryValue

[Rafael Espíndola]

> > You should write some tests to examine the behavior of VerQueryValue
> > with NULL puLen.
>
> I just found out that wine has a test for it, but it has been commented out:

The attached patch also uncomment the tests.

Cheers,
Rafael