Hi,
Now that the first 5 patches in the series are committed, I was wondering if there's any changes required in this patch (and 7/7) ?
Cheers, Aaryaman
On Mon, May 23, 2016 at 8:58 PM, Marvin testbot@winehq.org wrote:
Thank you for your contribution to Wine!
This is an automated notification to let you know that your patch has been reviewed and its status set to "Assigned".
This means that the patch has been assigned to a reviewer. If the reviewer signs off on the patch, it will be committed, otherwise you'll receive advice on how to improve it. If you don't hear anything after a couple of weeks, please resend the patch.
On 24 May 2016 at 16:49, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
Hi,
Now that the first 5 patches in the series are committed, I was wondering if there's any changes required in this patch (and 7/7) ?
Possibly, but this one is a bit more complicated than the 5 that came before, and I haven't reviewed it in detail yet.
On Tue, May 24, 2016 at 8:32 PM, Henri Verbeet hverbeet@gmail.com wrote:
On 24 May 2016 at 16:49, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
Hi,
Now that the first 5 patches in the series are committed, I was
wondering if
there's any changes required in this patch (and 7/7) ?
Possibly, but this one is a bit more complicated than the 5 that came before, and I haven't reviewed it in detail yet.
Sure, I will wait for your review :)
Cheers, Aaryaman
Any reviews? Should I resend this patch?
Cheers, Aaryaman
On Tue, May 24, 2016 at 8:36 PM, Aaryaman Vasishta < jem456.vasishta@gmail.com> wrote:
On Tue, May 24, 2016 at 8:32 PM, Henri Verbeet hverbeet@gmail.com wrote:
On 24 May 2016 at 16:49, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
Hi,
Now that the first 5 patches in the series are committed, I was
wondering if
there's any changes required in this patch (and 7/7) ?
Possibly, but this one is a bit more complicated than the 5 that came before, and I haven't reviewed it in detail yet.
Sure, I will wait for your review :)
Cheers, Aaryaman
On 31 May 2016 at 14:01, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
Any reviews? Should I resend this patch?
I had hoped to have reviewed this by now, but clearly haven't. I'm not sure when I will, but in the mean time, if you have easier patches, those don't necessarily need to wait for these to go in.
Yup, I'm working on frames and viewports right now. There's no immediate need for these to get in, but I hope it will, eventually :)
Cheers, Aaryaman
On Wed, Jun 1, 2016 at 12:51 AM, Henri Verbeet hverbeet@gmail.com wrote:
On 31 May 2016 at 14:01, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
Any reviews? Should I resend this patch?
I had hoped to have reviewed this by now, but clearly haven't. I'm not sure when I will, but in the mean time, if you have easier patches, those don't necessarily need to wait for these to go in.
-
Aaryaman Vasishta -
Henri Verbeet