How long should one wait to resend patches marked as "New" on the patch list? It seems that once they've gone "far enough" down on the list that there's no chance they'll be looked at. Thanks in advance for your advice.
Erich Hoover ehoover@mines.edu
On Sat, Oct 22, 2011 at 10:48, Erich Hoover ehoover@mines.edu wrote:
How long should one wait to resend patches marked as "New" on the patch list? It seems that once they've gone "far enough" down on the list that there's no chance they'll be looked at. Thanks in advance for your advice.
As with a lot of things in Wine, there is no hard rule, but on irc it's been mentioned a few times to wait until the patch falls off of the list.
On Sat, Oct 22, 2011 at 19:49, Austin English austinenglish@gmail.com wrote:
On Sat, Oct 22, 2011 at 10:48, Erich Hoover ehoover@mines.edu wrote:
How long should one wait to resend patches marked as "New" on the patch list? It seems that once they've gone "far enough" down on the list that there's no chance they'll be looked at. Thanks in advance for your advice.
As with a lot of things in Wine, there is no hard rule, but on irc it's been mentioned a few times to wait until the patch falls off of the list.
http://wiki.winehq.org/SubmittingPatches says "If your patch isn't committed in a day or two, improve it (perhaps by adding more tests) and resend, or ask on IRC/wine-devel for suggestions."
Might it be useful to add sthg like "If some other external changes would make your patch unapplicable, you may rebase/resend it with (resend) appended to the subject line"? Or should that be (try N+1) with (try N+1: rebase) comment in the "extended" patch subject?
2011/10/23 Frédéric Delanoy frederic.delanoy@gmail.com
On Sat, Oct 22, 2011 at 19:49, Austin English austinenglish@gmail.com wrote:
On Sat, Oct 22, 2011 at 10:48, Erich Hoover ehoover@mines.edu wrote:
How long should one wait to resend patches marked as "New" on the patch list? It seems that once they've gone "far enough" down on the list that there's no chance they'll be looked at. Thanks in advance for your advice.
As with a lot of things in Wine, there is no hard rule, but on irc it's been mentioned a few times to wait until the patch falls off of the list.
http://wiki.winehq.org/SubmittingPatches says "If your patch isn't committed in a day or two, improve it (perhaps by adding more tests) and resend, or ask on IRC/wine-devel for suggestions." ...
I believe that that comment is from before the patch tracker became available. It doesn't look like there's even a link on that page to the tracker... It seems like that page should probably be updated with a link to the tracker and a comment about waiting for the patch to fall off the list.
Erich Hoover ehoover@mines.edu
-
Austin English -
Erich Hoover -
Frédéric Delanoy