Re: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory

[Vitaliy Margolen]

Thursday, August 17, 2006, 2:08:25 PM, Mikolaj Zalewski wrote:
> When creating the wineprefix, create a directory for the menu and a 
> configuration file that enables this menu in the freedesktop.org menu 
> structure. As suggested on wine-devel the menu directory is a 
> subdirectory of ~/.wine, so if the user deletes it, all menu items 
> created there will be automatically removed.
> +<Name>Applications</Name>
> -
>
> <Menu>
> -
>    <Name>Wine</Name>
> -
>    <LegacyDir>__HOME__/.wine/menu</LegacyDir>
> -
>
> </Menu>
>
> +</Menu>

Why are you hard-coding this path to being .wine? You correctly used
$WINEPREFIX before.

Also that means that you should add files that are WINEPREFIX related. Or
you will keep overwriting the other ones.

Vitaliy Margolen

tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory

[Mikołaj Zalewski]

> > +<Name>Applications</Name>
> > -
> >
> > <Menu>
> > -
> >    <Name>Wine</Name>
> > -
> >    <LegacyDir>__HOME__/.wine/menu</LegacyDir>
> > -
> >
> > </Menu>
> >
> > +</Menu>
>
> Why are you hard-coding this path to being .wine? You correctly used
> $WINEPREFIX before.

I've forgot about WINEPREFIX here but when I added it there is a 
problem that wineprefixcreate is called with a directory like 
~/.wine-F6YHsT . If we make a reference to such a directory it won't work.
  Maybe we could keep it that wineprefixcreate creates the default file 
and document somewhere how to create the menu files if someone creates a 
custom wineprefix. Alternatively I could add a parameter to 
wineprefixcreate with the final name of the directory and make the menu 
filename dependent on this path.

Mikolaj