Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)

[Henri Verbeet]

On 17 July 2010 21:14, Misha Koshelev  wrote:
> @@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void)
>             IDirect3DVertexBuffer9_Release(vertex_buffer);
>         }
> - /* Index buffer */
> - number_of_faces = box->lpVtbl->GetNumFaces(box);
> - todo_wine ok( number_of_faces == 12, "Got result %u, expected 12\n",number_of_faces);
> -
>
> box->lpVtbl->Release(box);
>     }

I think this could easily have been part of the original test as well.
It's good to send small patches that make sense on their own, but I
don't think there's much to be gained by splitting up a patch that
adds a test for a single function.