"Andrew M. Johnston" johnstonam@logica.com writes:
This interim patch will do a little more drawing than is strictly necessary. (I hear what you asked re not changing names of things but in the interest of producing something this version does make the structure names lower case as is common else where and hence there are some irrelevant changes in SCROLL_GetScrollBarRect)
I still don't see much reason for renaming these things, but if you really want to do it, again a separate patch with just that change would be nicer. Also if you could avoid changing all the indentation it would make it a lot easier to see the real changes. Your patch breaks the scrollbars in notepad for me, but there are so many irrelevant differences that finding the bug is a lot more painful than it should be.
On Thu, 10 Oct 2002 04:27, Alexandre Julliard wrote:
I still don't see much reason for renaming these things, but if you really want to do it, again a separate patch with just that change would be nicer.
will send this as a separate patch shortly
Your patch breaks the scrollbars in notepad for me, but there are so many irrelevant differences that finding the bug is a lot more painful than it should be.
I assume that you mean that the tracking was not working correctly this was due to the change
if ((info->fMask & SIF_TRACKPOS) && (info->cbSize == sizeof(*info))) - info->nTrackPos = (SCROLL_TrackingWin == WIN_GetFullHandle(hwnd)) ? SCROLL_TrackingVal : infoPtr->curVal; + info->nTrackPos = infoPtr->curVal;
It can be removed by patch 4 but not at this stage.
I apologise although I played with the whole set of changes for hours looking at all sorts of corner cases, when I split the patch up I simply checked that it compiled and then used notepad and the file dialog in particular to check that it looked ok and responded to mouse events etc.
"Andrew M. Johnston" johnstonam@logica.com writes:
I assume that you mean that the tracking was not working correctly this was due to the change
if ((info->fMask & SIF_TRACKPOS) && (info->cbSize == sizeof(*info)))
info->nTrackPos = (SCROLL_TrackingWin == WIN_GetFullHandle(hwnd)) ? SCROLL_TrackingVal : infoPtr->curVal;
info->nTrackPos = infoPtr->curVal;It can be removed by patch 4 but not at this stage.
No the problem I see is that the scrollbar is always disabled no matter how large the notepad text is. I think the bug is that you set ESB_DISABLE_BOTH when SIF_DISABLENOSCROLL is set without taking into account the range of the scrollbar.
-
Alexandre Julliard -
Andrew M. Johnston