Re: urlmon: Skip more tests on old IE and ignore BINDSTATUS_PROXYDETECTING notification.

[Paul Vriens]

Jacek Caban wrote:
> dlls/urlmon/tests/url.c |  157 
> +++++++++++++++++++++++++----------------------
>  1 files changed, 84 insertions(+), 73 deletions(-)

Hi Jacek,

As of this patch we skip running most of the tests on Wine (and Windows). I only 
see a few W2K boxes that run the full tests for url.c (+/- 3800 tests). The rest 
only run 137 tests

urlmon: Skip more tests on old IE and ignore BINDSTATUS_PROXYDETECTING notification.

[Paul Vriens]

Paul Vriens wrote:
> Jacek Caban wrote:
> > dlls/urlmon/tests/url.c |  157 
> > +++++++++++++++++++++++++----------------------
> >  1 files changed, 84 insertions(+), 73 deletions(-)
>
> Hi Jacek,
>
> As of this patch we skip running most of the tests on Wine (and 
> Windows). I only see a few W2K boxes that run the full tests for url.c 
> (+/- 3800 tests). The rest only run 137 tests

Shouldn't that

if(!test_RegisterBindStatusCallback()) {

actually be

if(test_RegisterBindStatusCallback()) {

urlmon: Skip more tests on old IE and ignore BINDSTATUS_PROXYDETECTING notification.

[Jacek Caban]

Paul Vriens wrote:
> Paul Vriens wrote:
> > Jacek Caban wrote:
> > > dlls/urlmon/tests/url.c |  157 
> > > +++++++++++++++++++++++++----------------------
> > >  1 files changed, 84 insertions(+), 73 deletions(-)
> >
> > Hi Jacek,
> >
> > As of this patch we skip running most of the tests on Wine (and 
> > Windows). I only see a few W2K boxes that run the full tests for 
> > url.c (+/- 3800 tests). The rest only run 137 tests
>
> Shouldn't that
>
> if(!test_RegisterBindStatusCallback()) {
>
> actually be
>
> if(test_RegisterBindStatusCallback()) {

Yes, it should. It's fixed by my yesterday (not yet applied) patch.

Thanks,
    Jacek

urlmon: Skip more tests on old IE and ignore BINDSTATUS_PROXYDETECTING notification.

[Paul Vriens]

Jacek Caban wrote:
> Paul Vriens wrote:
> > Paul Vriens wrote:
> > > Jacek Caban wrote:
> > > > dlls/urlmon/tests/url.c |  157 
> > > > +++++++++++++++++++++++++----------------------
> > > >  1 files changed, 84 insertions(+), 73 deletions(-)
> > >
> > > Hi Jacek,
> > >
> > > As of this patch we skip running most of the tests on Wine (and 
> > > Windows). I only see a few W2K boxes that run the full tests for 
> > > url.c (+/- 3800 tests). The rest only run 137 tests
> >
> > Shouldn't that
> >
> > if(!test_RegisterBindStatusCallback()) {
> >
> > actually be
> >
> > if(test_RegisterBindStatusCallback()) {
>
> Yes, it should. It's fixed by my yesterday (not yet applied) patch.
>
> Thanks,
>    Jacek

Great !!

I just noticed it because I got an "err:ole:CoUninitialize Mismatched 
CoUninitialize" error ans started investigating.

The CoUninitialize should be moved inside the if(). I'll sent a patch once your 
stuff is in.