Re: shellexecute patch

[Andreas Mohr]

On Thu, Feb 14, 2002 at 11:57:55AM +0100, Rein Klazes wrote:
> Needed for Visual Studio.NET installer.
>
> Changelog:
>
> dlls/shell32	: shell.c
>    In ShellExecute16, make sure there is a space between command
>    and parameters.

Hmm, I suspect that might be wrong.
(in case your ShellExecute16() is being called by ShellExecute(), that is)

ShellExecute() was supposed to call WinExec() instead of WinExec16()
(long filename support).

I wrote a ShellExecute patch some weeks ago that didn't get applied,
probably because there were compile warnings.

But I might be wrong and your patch is completely independent of mine.

shellexecute patch

[Rein Klazes]

On Thu, 14 Feb 2002 19:14:28 +0100, you wrote:
> On Thu, Feb 14, 2002 at 11:57:55AM +0100, Rein Klazes wrote:
> > Needed for Visual Studio.NET installer.
> >
> > Changelog:
> >
> > dlls/shell32	: shell.c
> >    In ShellExecute16, make sure there is a space between command
> >    and parameters.
>
> Hmm, I suspect that might be wrong.
> (in case your ShellExecute16() is being called by ShellExecute(), that is)
>
> ShellExecute() was supposed to call WinExec() instead of WinExec16()
> (long filename support).
>
> I wrote a ShellExecute patch some weeks ago that didn't get applied,
> probably because there were compile warnings.
>
> But I might be wrong and your patch is completely independent of mine.

I think so. The patch is just preventing that ShellExecuteA( ...,
"K:\setup.exe","option",...) will cause a call to 
WinExec16("K:\setup.exeoption") that fails for a "file not found"
error.

Rein.

shellexecute patch

[Andreas Mohr]

On Thu, Feb 14, 2002 at 07:40:54PM +0100, Rein Klazes wrote:
> On Thu, 14 Feb 2002 19:14:28 +0100, you wrote:
> > But I might be wrong and your patch is completely independent of mine.
>
> I think so. The patch is just preventing that ShellExecuteA( ...,
> "K:\setup.exe","option",...) will cause a call to 
> WinExec16("K:\setup.exeoption") that fails for a "file not found"
> error.

Hmm, thinking more about it (hmm, should have done that before :),
I guess you're absolutely and completely 100% right.

I really don't want to know how many installers failed due to this problem...
(I'm certainly remembering several cases that almost cry for correlation
to this fix...)