Could you revert recent Japanese translation updates[1] or commit attached patch? As I mention in the last mail[2], patch 91758[3] has some issues, especially when retrieving shell path names. Although path names are not localized in Japanese Windows Vista (and its successors), they are (mistakenly?) included in the last commit. To prove this, I submitted a job to winetestbot [4]. However, new winetestbot seems to be stuck. Alternatively, I attach my Japanese Windows 7 result. The line which begins shellpath.c:443 is my additional output. You can see that all path names are not translated.
[1] http://source.winehq.org/git/wine.git/commit/0fb9de61a5026ac6cf16bc3385c3828... [2] http://www.winehq.org/pipermail/wine-devel/2013-June/100377.html [3] http://source.winehq.org/patches/data/97158 [4] https://newtestbot.winehq.org/JobDetails.pl?Key=1432 --- po/ja.po | 63 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 31 insertions(+), 32 deletions(-)
Akihiro Sagawa sagawa.aki@gmail.com writes:
Could you revert recent Japanese translation updates[1] or commit attached patch? As I mention in the last mail[2], patch 91758[3] has some issues, especially when retrieving shell path names. Although path names are not localized in Japanese Windows Vista (and its successors), they are (mistakenly?) included in the last commit.
Then they should be explicitly "translated" to the same English string instead of an empty string, this way it doesn't look like the translation is missing.
On Wed, 03 Jul 2013 16:23:11 +0200, Alexandre Julliard wrote:
Akihiro Sagawa sagawa.aki@gmail.com writes:
As I mention in the last mail[2], patch 91758[3] has some issues, especially when retrieving shell path names. Although path names are not localized in Japanese Windows Vista (and its successors), they are (mistakenly?) included in the last commit.
Then they should be explicitly "translated" to the same English string instead of an empty string, this way it doesn't look like the translation is missing.
I got it. I'll resubmit the patch.
Actually, it was removed by 4c4e51700932e9ed6355afc1bf8ca0d18282634f. I misunderstood the intention of the commit at that time.
Regards, Akihiro Sagawa
On Thu, 4 Jul 2013, Akihiro Sagawa wrote: [...]
I got it. I'll resubmit the patch.
Actually, it was removed by 4c4e51700932e9ed6355afc1bf8ca0d18282634f. I misunderstood the intention of the commit at that time.
At the time the PO files were new and had been populated from the RC files which were incompletely translated. So I made a pass over them to remove strings that seemed to unintentionally not be translated so that a translator would later get a chance to look at them again.
As I mention in the last mail[2], patch 91758[3] has some issues, especially when retrieving shell path names. Although path names are not localized in Japanese Windows Vista (and its successors), they are (mistakenly?) included in the last commit.
Note that although the on-disk directory names are not translated in Windows 7, the shell folders contain desktop.ini files that result in the display names to be translated (see attached screenshot).
On Windows XP at least some shell folder names were getting translated on-disk. This was the case for 'Program Files' in French for instance. I don't know what was done for Japanese in that case though.
Now as far as I can tell Wine does not use the desktop.ini approach at this point. So whether to translate these shell folder names depends on:
* Whether they were translated in the Japanese Windows XP editions.
* These names are also used to detect the corresponding Unix folders, at least in the non-XDG case. The Unix folder names may be translated so it requires us to look for them by the right name.
-
Akihiro Sagawa -
Alexandre Julliard -
Francois Gouget