Re: wined3d: Remove unneeded "extern" from function definition

[James Hawkins]

On Wed, May 21, 2008 at 3:50 PM, Andrew Talbot
 wrote:
> Changelog:
>    wined3d: Remove unneeded "extern" from function definition.
>
> diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
> index 7a1a355..684690b 100644
> --- a/dlls/wined3d/surface.c
> +++ b/dlls/wined3d/surface.c
> @@ -2489,7 +2489,7 @@ HRESULT WINAPI IWineD3DSurfaceImpl_SaveSnapshot(IWineD3DSurface *iface, const ch
>  /**
> - Slightly inefficient way to handle multiple dirty rects but it works :)
>
> */
> -extern HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) {
> +HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) {
>     IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface;
>     IWineD3DBaseTexture *baseTexture = NULL;

These interface implementations could even be made static.

wined3d: Remove unneeded "extern" from function definition

[Andrew Talbot]

James Hawkins wrote:
> These interface implementations could even be made static.

That's true. I shall still leave this patch in for consideration, since I
don't have time, right now, to properly consider what can be made static in
this dll. I hope to do so another time.

Thanks,

wined3d: Remove unneeded "extern" from function definition

[James Hawkins]

On Wed, May 21, 2008 at 4:44 PM, Andrew Talbot
 wrote:
> James Hawkins wrote:
> > These interface implementations could even be made static.
>
> That's true. I shall still leave this patch in for consideration, since I
> don't have time, right now, to properly consider what can be made static in
> this dll. I hope to do so another time.

Sure.  It's a pretty easy decision for interface implementations:
since the functions are accessed through an instantiated object, the
actual functions shouldn't be needed outside the source file they
reside in, and that's the definition of which functions qualify for
'static'.