Re: [PATCH] gdi32: Report unsubstituted font face names. (try 3)

[Alex Henrie]

2014-05-08 2:28 GMT-06:00 Alexandre Julliard :
> Please add tests for the full name too.

I thought I did:

@@ -6031,6 +6042,8 @@ START_TEST(font)
      * I'd like to avoid them in this test.
      */
     test_EnumFontFamilies("Arial Black", ANSI_CHARSET);
+    test_EnumFontFamilies("MS Shell Dlg", ANSI_CHARSET);
+    test_EnumFontFamilies("MS Shell Dlg 2", ANSI_CHARSET);
     test_EnumFontFamilies("Symbol", SYMBOL_CHARSET);
     if (is_truetype_font_installed("Arial Black") &&
         (is_truetype_font_installed("Symbol") || is_truetype_font_installed("Wingdings")))

Is there a better way to test the full name?

-Alex

[PATCH] gdi32: Report unsubstituted font face names. (try 3)

[Alexandre Julliard]

Alex Henrie  writes:
> 2014-05-08 2:28 GMT-06:00 Alexandre Julliard :
> > Please add tests for the full name too.
>
> I thought I did:
>
> @@ -6031,6 +6042,8 @@ START_TEST(font)
>       * I'd like to avoid them in this test.
>       */
>      test_EnumFontFamilies("Arial Black", ANSI_CHARSET);
> - test_EnumFontFamilies("MS Shell Dlg", ANSI_CHARSET);
> - test_EnumFontFamilies("MS Shell Dlg 2", ANSI_CHARSET);

That only tests that the font is found, but not what is enumerated as
full name for it. You probably want to use enum_fullname_data_proc or
something along those lines.