Re: winemaker: Be less picky when detecting the target type

[Francois Gouget]

On Fri, 11 Nov 2011, André Hentschel wrote:
> seen some "broken" project files which still worked with msvc but not with winemaker
>
> tools/winemaker |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/winemaker b/tools/winemaker
> index 2ee79ea..921f8ef 100755
> --- a/tools/winemaker
> +++ b/tools/winemaker
> @@ -589,16 +589,16 @@ sub source_scan_project_file($$$)
>                  #print $prj_name;
>                  next;
>              } elsif (/^# TARGTYPE/) {
> -
>            if (/[[:space:]]0x0101$/) {
> -
>            if (/0x.*101$/) {

The various .* worry me a bit. Would something like [0-9a-fA-F]* be 
permissive enough?

winemaker: Be less picky when detecting the target type

[Vitaliy Margolen]

On 11/14/2011 04:04 AM, Francois Gouget wrote:
> On Fri, 11 Nov 2011, André Hentschel wrote:
> > seen some "broken" project files which still worked with msvc but not with winemaker
> >
> > tools/winemaker |    8 ++++----
> >   1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/winemaker b/tools/winemaker
> > index 2ee79ea..921f8ef 100755
> > --- a/tools/winemaker
> > +++ b/tools/winemaker
> > @@ -589,16 +589,16 @@ sub source_scan_project_file($$$)
> >                   #print $prj_name;
> >                   next;
> >               } elsif (/^# TARGTYPE/) {
> > -
> >            if (/[[:space:]]0x0101$/) {
> > -
> >            if (/0x.*101$/) {
>
> The various .* worry me a bit. Would something like [0-9a-fA-F]* be
> permissive enough?

I think he was trying to match "x" too. At a very minimum the match needs to 
be less greedy (.*?).

Vitaliy.