On 06.08.2015 23:14, xantares 09 wrote:
From: Jonathan Vollebregt jnvsor@gmail.com
programs/reg/reg.c | 85 +++++++++++++++++++++++++++--------------------------- 1 file changed, 43 insertions(+), 42 deletions(-)
It is a bit pointless to send patches anonymously to the wine-patches mailing list. No matter if you are the author or not, when you are sending the patches you are the person responsible for it. To establish trust, all developers should use their real names here on the mailing lists. (see the rules for submitting patches: http://wiki.winehq.org/SubmittingPatches )
Besides that I see much bigger chances when Jonathan would send these patches himself. He is experienced with his own code, can respond to feedback, can fix regressions if it causes problems, and so on. For people new to Wine development its always easier to start with some self-written patches.
@Jonathan: I would like to encourage you again to give it another try. If you need any help, feel free to ask me. I assume Stefan Dösinger would also be willing to help again.
Regards, Sebastian
Subject: Re: [PATCH 1/2] reg: simplify root key search To: xantares09@hotmail.com CC: jnvsor@gmail.com; wine-devel@winehq.org From: sebastian@fds-team.de Date: Thu, 6 Aug 2015 23:57:17 +0200
On 06.08.2015 23:14, xantares 09 wrote:
From: Jonathan Vollebregt jnvsor@gmail.com
programs/reg/reg.c | 85 +++++++++++++++++++++++++++--------------------------- 1 file changed, 43 insertions(+), 42 deletions(-)
It is a bit pointless to send patches anonymously to the wine-patches mailing list. No matter if you are the author or not, when you are sending the patches you are the person responsible for it. To establish trust, all developers should use their real names here on the mailing lists. (see the rules for submitting patches: http://wiki.winehq.org/SubmittingPatches )
Besides that I see much bigger chances when Jonathan would send these patches himself. He is experienced with his own code, can respond to feedback, can fix regressions if it causes problems, and so on. For people new to Wine development its always easier to start with some self-written patches.
@Jonathan: I would like to encourage you again to give it another try. If you need any help, feel free to ask me. I assume Stefan Dösinger would also be willing to help again.
Regards, Sebastian
He didn't seem to be willing to work on wine anymore, but I hope I'm wrong.
I saved his previous patchset and adapted the query patch to wine-staging for someone brave enough to take it upstream: https://github.com/wine-compholio/wine-staging/pull/322
xan.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
Sorry, I've been a bit lazy with replying to your mail...
Am 2015-08-08 um 13:20 schrieb xantares 09:
He didn't seem to be willing to work on wine anymore, but I hope I'm wrong.
I saved his previous patchset and adapted the query patch to wine-staging for someone brave enough to take it upstream: https://github.com/wine-compholio/wine-staging/pull/322
I like the content of the two patches you sent. The only thing that's missing from my point of view is your real name.
I don't really know at which point AJ accepts patches from someone who isn't the original author. There are plenty of patches in the code that were cleaned up and submitted by someone else.
-
Sebastian Lackner -
Stefan Dösinger -
xantares 09