Hi Rein,
Indeed, what happens if you try this obvious patch:
(snip context) - if ((width >= 0x10000) || (height >= 0x10000)) + if ((height && width >= 0x10000) || (width && height >= 0x10000))
This obvious patch is quite wrong, height && width evaluantes to either 0 or 1, same with width && height, so now the fixme will never be produced.
--Juan
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
On Mon, 2 May 2005 09:29:41 -0700 (PDT), you wrote:
Hi Rein,
Indeed, what happens if you try this obvious patch:
(snip context)
- if ((width >= 0x10000) || (height >= 0x10000))
- if ((height && width >= 0x10000) || (width && height >= 0x10000))
This obvious patch is quite wrong, height && width evaluantes to either 0 or 1, same with width && height, so now the fixme will never be produced.
Operator ">=" has precedence over "&&", so the evaluation is as:
if ((height && (width >= 0x10000)) || (width && (height >= 0x10000)))
Rein.