Hans Leidekker hans@it.vu.nl writes:
Uncomment some tests in rtlstr.c and wrap them in todo_wine{} instead.
You can't do that, many of these tests succeed, which is not allowed inside todo_wine. And please try a 'make test' when you change a test, as already explained there's no point in submitting a patch that causes make test to fail.
On Monday 15 December 2003 21:19, Alexandre Julliard wrote:
You can't do that, many of these tests succeed, which is not allowed inside todo_wine. And please try a 'make test' when you change a test, as already explained there's no point in submitting a patch that causes make test to fail.
Sorry, will do next time. I can understand that failing tests should not be committed, but this scheme forces todo_wine on them which then results in a cover-up for problematic tests. I simply got used to running test directly instead of through 'make test'.
-Hans
-
Alexandre Julliard -
Hans Leidekker