Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string.

[Ken Thomases]

Hi,

On Jul 23, 2013, at 10:26 PM, Charles Davis wrote:
> @@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void)
>     gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1);
>     strcpy(gl_info.glVersion, str);
>     str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS);
> - gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1);
> - gl_info.glExtensions = HeapAlloc(GetProcessHeap(), 0, strlen(str) +
> -
>    sizeof(" WGL_EXT_extensions_string WGL_EXT_swap_control"));
> strcpy(gl_info.glExtensions, str);
> - strcat(gl_info.glExtensions, " WGL_EXT_extensions_string WGL_EXT_swap_control");

As a minor nitpick, I would prefer to avoid that duplicated string literal.

Otherwise, looks good to me.

Cheers,
Ken