Re: [PATCH 2/2] explorer: use winediag for some error messages

[Sebastian Lackner]

On 16.11.2015 06:04, Austin English wrote:
>      case ERROR_MOD_NOT_FOUND:
> -
>        strcpy( error, "The graphics driver is missing. Check your build!" );
> -
>        ERR_(winediag)( error, "The graphics driver is missing. Check your build!" );
>        break;

This can't work, you pass an uninitialized string to ERR(). Also, the current implementation
just saves the error in the registry, and it is later loaded and printed by user32/driver.c.

What you probably wanted to do is to replace both MESSAGE() calls with ERR_(winediag) in patch 1/2:

--- snip ---
-    MESSAGE( "Application tried to create a window, but no driver could be loaded.\n");
+    ERR_(winediag)( "Application tried to create a window, but no driver could be loaded.\n");
     if (driver_load_error[0]) MESSAGE( "%s\n", driver_load_error ); <----------------------------
--- snip ---

Regards,
Sebastian