Re: [1/4] combase: Add TRACEs to string functions.

[Alistair Leslie-Hughes]

Hi Sebastian,

On 25/10/15 14:43, Sebastian Lackner wrote:
> Signed-off-by: Sebastian Lackner
> @@ -95,6 +100,9 @@ HRESULT WINAPI WindowsCreateStringReference(LPCWSTR ptr, UINT32 len,
>                                               HSTRING_HEADER *header, HSTRING *out)
>   {
>       struct hstring_private *priv = impl_from_HSTRING_HEADER(header);
> -
> - TRACE("(%p, %u, %p, %p)\n", ptr, len, header, out);

Would it make sense to output ptr as a string?

Best Regards
  Alistair Leslie-Hughes

[1/4] combase: Add TRACEs to string functions.

[Sebastian Lackner]

On 25.10.2015 09:38, Alistair Leslie-Hughes wrote:
> Hi Sebastian,
>
> On 25/10/15 14:43, Sebastian Lackner wrote:
> > Signed-off-by: Sebastian Lackner
> > @@ -95,6 +100,9 @@ HRESULT WINAPI WindowsCreateStringReference(LPCWSTR ptr, UINT32 len,
> >                                               HSTRING_HEADER *header, HSTRING *out)
> >   {
> >       struct hstring_private *priv = impl_from_HSTRING_HEADER(header);
> > -
> > - TRACE("(%p, %u, %p, %p)\n", ptr, len, header, out);
>
> Would it make sense to output ptr as a string?
>
> Best Regards
>  Alistair Leslie-Hughes

Thanks, it indeed makes sense. I've sent a fixed version.

Best regards,
Sebastian