Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)

[Dmitry Timoshkov]

Louis Lenders  wrote:
> - SetLastError(0xdadadada);
> - retval = UpdateWindow(NULL);
> - ok( !retval, "Expected 0, got %d\n", retval);
> - ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError());

It's better to use a commonly accepted 0xdeadbeef as an invalid last error
value, and limit the line length somewhere at 80.

Line Length (Was: Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2))

[Michael Stefaniuc]

Dmitry Timoshkov wrote:
> Louis Lenders  wrote:
> > - SetLastError(0xdadadada);
> > - retval = UpdateWindow(NULL);
> > - ok( !retval, "Expected 0, got %d\n", retval);
> > - ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError());
>
> It's better to use a commonly accepted 0xdeadbeef as an invalid last error
> value, and limit the line length somewhere at 80.

A line length of 80 is kinda outdated, I have talked to Alexandre and he
considers 100 a better value. I would have preferred 120 to hold for a
while.

bye
    michael

Line Length (Was: Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2))

[Wolfram Sang]

> > It's better to use a commonly accepted 0xdeadbeef as an invalid last error
> > value, and limit the line length somewhere at 80.
>
> A line length of 80 is kinda outdated, I have talked to Alexandre and he
> considers 100 a better value. I would have preferred 120 to hold for a
> while.

+1 \o/