Hi John,
First of all this are basically two changes in one patch. Keep the vendor one separated from the device string. Second the opengl renderer string shouldn't be directly returned. In short d3d apps can query the pci id and opengl doesn't expose it (we aren't allowed to use /proc for card detection or so) and for that reason we 'estimate' what card is used based on the gpu capabilities (supported opengl extensions) and later on also the renderer string to refine the result a bit. For this reason the renderer string doesn't have to be the same as the pci id that we report. There are still some changes I have to make to the code and add a device string database.
Roderick
On Wed, Apr 8, 2009 at 8:40 AM, John Whitlock John-Whitlock@ieee.orgwrote:
Use the OpenGL renderer for the device description Use the OpenGL vendor to pick an appropriate XP device driver Fixes bug 15839
The registry overrides seemed to make devs uncomfortable, so I'm trying submitting without them. They are easy enough to add on top of this change, if the need arises in the future.
For my curiosity, why can't we use /proc for card detection?
If the right thing to do is create a device string database, then it seem the registry override patch is the way to go. This way, the bug is addressed today and users can move on. In the future, when the device string database is in place, there will be cases where we get it wrong, and the users will still want the ability to override the autopicked settings.
Does this sound reasonable? Do other devs agree?
John
On Wed, Apr 8, 2009 at 12:58 AM, Roderick Colenbrander < thunderbird2k@gmail.com> wrote:
Hi John,
First of all this are basically two changes in one patch. Keep the vendor one separated from the device string. Second the opengl renderer string shouldn't be directly returned. In short d3d apps can query the pci id and opengl doesn't expose it (we aren't allowed to use /proc for card detection or so) and for that reason we 'estimate' what card is used based on the gpu capabilities (supported opengl extensions) and later on also the renderer string to refine the result a bit. For this reason the renderer string doesn't have to be the same as the pci id that we report. There are still some changes I have to make to the code and add a device string database.
Roderick
On Wed, Apr 8, 2009 at 8:40 AM, John Whitlock John-Whitlock@ieee.orgwrote:
Use the OpenGL renderer for the device description Use the OpenGL vendor to pick an appropriate XP device driver Fixes bug 15839
The registry overrides seemed to make devs uncomfortable, so I'm trying submitting without them. They are easy enough to add on top of this change, if the need arises in the future.
Am Mittwoch, 8. April 2009 16:16:06 schrieb John Whitlock:
For my curiosity, why can't we use /proc for card detection?
Because it isn't portable. Wine runs not only on Linux, but also on Solaris, Mac OS X, *BSD, ...
-
John Whitlock -
Roderick Colenbrander -
Stefan Dösinger