Re: shdocvw: Correct OnAmbientPropertyChange regession

[Jacek Caban]

Alistair Leslie-Hughes wrote:
> Hi,
>    After testing on XP, it appears that OnAmbientPropertyChange when 
> passwed DISP_UNKNOWN doesnt check all properties.
>
> Changelog:
>     shdocvw: Correct OnAmbientPropertyChange regession

+    CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED);
+    CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT);
+    CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE);
+    CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL);
+    CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT);
+    CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE);

These checks don't make sense here. If you don't set these calls as 
expected, CHECK_EXPECT will fail when they are called.

Jacek

shdocvw: Correct OnAmbientPropertyChange regession

[Alistair Leslie-Hughes]

"Jacek Caban"  wrote in message 
news:[e-mail]...
> Alistair Leslie-Hughes wrote:
> > Hi,
> >    After testing on XP, it appears that OnAmbientPropertyChange when
> > passwed DISP_UNKNOWN doesnt check all properties.
> >
> > Changelog:
> >     shdocvw: Correct OnAmbientPropertyChange regession
> - CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED);
> - CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT);
> - CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE);
> - CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL);
> - CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT);
> - CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE);
>
> These checks don't make sense here. If you don't set these calls as
> expected, CHECK_EXPECT will fail when they are called.

Hi Jacek.

I was unsure about the SET_EXPECT.  Thanks

Best Regards
 Alistair Leslie-Hughes