shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

[Paul Vriens]

Hi,

I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 
box. When I crosscompile the full winetest and run "winetest shlwapi:shreg" on 
my Win95 box the test results are:

shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127)
shreg.c:274: Test failed: Expected ERROR_MORE_DATA, got (127)

When I now build just the shlwapi test the tests succeed (dwRet = 203)

Any idea where these differences could come from? '203' is 
ERROR_ENVVAR_NOT_FOUND btw. '127' is ERROR_PROC_NOT_FOUND.

Only ERROR_ENVVAR_NOT_FOUND sounds at least a little bit like a proper result as 
we are dealing with expanding envvars. ERROR_PROC_NOT_FOUND doesn't make sense 
at all.

shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

[Reece Dunn]

2009/3/9 Paul Vriens :
> Hi,
>
> I'm trying to fix the last remaining test failures for shlwapi/shreg on my
> Win95 box. When I crosscompile the full winetest and run "winetest
> shlwapi:shreg" on my Win95 box the test results are:
>
> shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127)
> shreg.c:274: Test failed: Expected ERROR_MORE_DATA, got (127)
>
> When I now build just the shlwapi test the tests succeed (dwRet = 203)
>
> Any idea where these differences could come from? '203' is
> ERROR_ENVVAR_NOT_FOUND btw. '127' is ERROR_PROC_NOT_FOUND.
>
> Only ERROR_ENVVAR_NOT_FOUND sounds at least a little bit like a proper
> result as we are dealing with expanding envvars. ERROR_PROC_NOT_FOUND
> doesn't make sense at all.

A quick google points to ERROR_PROC_NOT_FOUND being set if
LoadLibraryEx/GetProcAddress fails.

Is the GetLastError() state being contaminated by previous calls?
(I.e. is the Win95 box not setting the last error state).

- Reece

shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

[Paul Vriens]

Reece Dunn wrote:
> 2009/3/9 Paul Vriens :
> > Hi,
> >
> > I'm trying to fix the last remaining test failures for shlwapi/shreg on my
> > Win95 box. When I crosscompile the full winetest and run "winetest
> > shlwapi:shreg" on my Win95 box the test results are:
> >
> > shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127)
> > shreg.c:274: Test failed: Expected ERROR_MORE_DATA, got (127)
> >
> > When I now build just the shlwapi test the tests succeed (dwRet = 203)
> >
> > Any idea where these differences could come from? '203' is
> > ERROR_ENVVAR_NOT_FOUND btw. '127' is ERROR_PROC_NOT_FOUND.
> >
> > Only ERROR_ENVVAR_NOT_FOUND sounds at least a little bit like a proper
> > result as we are dealing with expanding envvars. ERROR_PROC_NOT_FOUND
> > doesn't make sense at all.
>
> A quick google points to ERROR_PROC_NOT_FOUND being set if
> LoadLibraryEx/GetProcAddress fails.
>
> Is the GetLastError() state being contaminated by previous calls?
> (I.e. is the Win95 box not setting the last error state).
> - Reece

No, that isn't it as most other calls to the same functions succeed/fail without 
a problem.

It also doesn't explain the difference.