[PATCH] msvfw32/tests: add a few tests for MCIWndCreate

[Dmitry Timoshkov]

David Adam  wrote:
> static void test_MCIWndCreate(void)
>  {
> - HWND parent, window;
> - int i;
> - HWND parent, window, window2;
> HMODULE hinst = GetModuleHandleA(NULL);
> char fname[MAX_PATH];
> char invalid_fname[] = "invalid.avi";
> char error[200];
> LRESULT ret;
> - unsigned long int result;
> - unsigned long int always_set_style, expected_style, style;
> - unsigned long int given_style[]= { MCIWNDF_NOAUTOSIZEWINDOW, MCIWNDF_NOAUTOSIZEMOVIE, MCIWNDF_NOMENU,
> -
>    MCIWNDF_RECORD, MCIWNDF_SHOWMODE, MCIWNDF_SHOWNAME, MCIWNDF_SHOWPOS };

Please try to follow win32 types. Using 'long' is almost always wrong.

[David Adam]

Hello,
any news for this patch?

Le sam. 3 oct. 2020 à 22:46, Dmitry Timoshkov  a écrit :
> David Adam  wrote:
> > static void test_MCIWndCreate(void)
> >  {
> > - HWND parent, window;
> > - int i;
> > - HWND parent, window, window2;
> > HMODULE hinst = GetModuleHandleA(NULL);
> > char fname[MAX_PATH];
> > char invalid_fname[] = "invalid.avi";
> > char error[200];
> > LRESULT ret;
> > - unsigned long int result;
> > - unsigned long int always_set_style, expected_style, style;
> > - unsigned long int given_style[]= { MCIWNDF_NOAUTOSIZEWINDOW,
>
> MCIWNDF_NOAUTOSIZEMOVIE, MCIWNDF_NOMENU,
> > -
> >    MCIWNDF_RECORD, MCIWNDF_SHOWMODE, MCIWNDF_SHOWNAME,
>
> MCIWNDF_SHOWPOS };
>
> Please try to follow win32 types. Using 'long' is almost always wrong.
>
> --
> Dmitry.