On April 14, 2003 06:11 pm, Uwe Bonnes wrote:
MESSAGE( "Falling back to ttydrv\n");
Again, I'd say this message is not appropriate, especially now that the user has to enable this configurations. For people using command line tools under Wine will be just pure spam.
"Dimitrie" == Dimitrie O Paun dpaun@rogers.com writes:
Dimitrie> On April 14, 2003 06:11 pm, Uwe Bonnes wrote: >> + MESSAGE( "Falling back to ttydrv\n");
Dimitrie> Again, I'd say this message is not appropriate, especially now Dimitrie> that the user has to enable this configurations. For people Dimitrie> using command line tools under Wine will be just pure spam.
Should the message have higher or lower annoyance levels?
On Tue, Apr 15, 2003 at 11:25:44AM +0200, Uwe Bonnes wrote:
"Dimitrie" == Dimitrie O Paun dpaun@rogers.com writes:
Dimitrie> On April 14, 2003 06:11 pm, Uwe Bonnes wrote: >> + MESSAGE( "Falling back to ttydrv\n"); Dimitrie> Again, I'd say this message is not appropriate, especially now Dimitrie> that the user has to enable this configurations. For people Dimitrie> using command line tools under Wine will be just pure spam.
Should the message have higher or lower annoyance levels?
He probably wants it to disappear. I think we need that, however, since it is non-intuitive behaviour to completely silently fall back to ttydrv-only output when DISPLAY is not set. (just think of how many people were completely puzzled due to wineinstall failing and leaving GraphicsDriver set to ttydrv in the config file at some time!) Anyway, in its current form the message is probably not very useful, since it doesn't explain what really happened. Note also that by providing the fallback, you are silencing the usual Error: Can't open display: message (which incidentally is not very useful either ;) which people could search for on the Internet to find the reason why Wine doesn't work at all. Instead, we'd silently fall back to text (not giving any message to assist people), thus worsening the situation: from a non-working wine and a badly understandable but at least searchable error to an almost non-working wine (ttydrv) and no error at all to get a clue from.
Thus I'd have a message and change it to something like Warning: environment variable DISPLAY [which is ]needed for X11 graphics output not set, thus falling back to [ttydrv] text-only output [, no graphics displayed].
Parts in [] are optional but maybe useful.
Or maybe a much better form would be Warning: environment variable DISPLAY not set: no X11 graphics output possible, [I ]need to fall back to text-only output [via ttydrv].
And we must have an option in .wine/config to disable this permanently for users that dont use X11.
Thus I'd have a message and change it to something like Warning: environment variable DISPLAY [which is ]needed for X11 graphics output not set, thus falling back to [ttydrv] text-only output [, no graphics displayed].
Parts in [] are optional but maybe useful.
Or maybe a much better form would be Warning: environment variable DISPLAY not set: no X11 graphics output possible, [I ]need to fall back to text-only output [via ttydrv].
===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War !
"What if tomorrow the War could be over ?" Morpheus, in "Reloaded".
For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth.
___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
On Tue, Apr 15, 2003 at 12:56:40PM +0200, Sylvain Petreolle wrote:
And we must have an option in .wine/config to disable this permanently for users that dont use X11.
For users that don't use X11, the wine config file would contain ttydrv by default, so the fallback message wouldn't get printed. Let's just assume people who use Wine for text-only output know what they're doing... ;)
Andreas Mohr
On Tue, 15 Apr 2003, Uwe Bonnes wrote:
Should the message have higher or lower annoyance levels?
If the user configured Wine like so, why output a message at all?
Hi,
On Tue, Apr 15, 2003 at 08:27:07AM -0400, Dimitrie O. Paun wrote:
On Tue, 15 Apr 2003, Uwe Bonnes wrote:
Should the message have higher or lower annoyance levels?
If the user configured Wine like so, why output a message at all?
That's true. In fact I'm afraid that I wasn't aware of the config key. If you have to explicitly configure this behaviour, then omitting a message is not such a terrible idea... Sorry ;-)