On 4/24/2010 12:53, Ilya Basin wrote:
- removes the block of code that splits lpFile into filename and
parameters and removes '"'s from filename . Even without this block ShellExecute not fails with quoted lpFile.
- removes 2 corresponding todo_wine's from tests.
The real application affected by this bug is uTorrent: if you have 2 downloads containing, say, "foo/bar.avi" and "foo 2/baz.avi", when you double click the latter avi file, it'll open the explorer in folder "foo" instead.
try 2: disabled todo_wine for "%s\masked file.shlexec" instead of disabling all todo_wine's in the loop
try 3: try 2 didn't apply cleanly in git: ok() format string changed.
dlls/shell32/shlexec.c | 62 +----------------------------------------- dlls/shell32/tests/shlexec.c | 16 +++++------ 2 files changed, 8 insertions(+), 70 deletions(-)
diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c index a81cada..b89bb08 100644 --- a/dlls/shell32/shlexec.c +++ b/dlls/shell32/shlexec.c @@ -1678,67 +1678,7 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc ) /* Else, try to execute the filename */ TRACE("execute:%s,%s,%s\n", debugstr_w(wszApplicationName), debugstr_w(wszParameters), debugstr_w(wszDir));
- /* separate out command line arguments from executable file name */
Where are tests for this separation path? You know, it's suspicious to just remove it to solve for not-clearly related problem to this code block.
-
Nikolay Sivov