[PATCH v2 2/9] adsldp: Require attribute definition to be properly terminated.

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov 
---
 dlls/adsldp/schema.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/adsldp/schema.c b/dlls/adsldp/schema.c
index 32b11a361a..06e61f258a 100644
--- a/dlls/adsldp/schema.c
+++ b/dlls/adsldp/schema.c
@@ -183,7 +183,7 @@ static BOOL parse_attribute_type(WCHAR *str, struct attribute_type *at)
     while (*p)
     {
         while (is_space(*p)) p++;
-        if (*p == ')') break;
+        if (*p == ')') return TRUE;

if (!wcsnicmp(p, L"NAME", 4))
         {
@@ -228,7 +228,10 @@ static BOOL parse_attribute_type(WCHAR *str, struct attribute_type *at)
         }
     }

-    return TRUE;
+    WARN("attribute definition is not terminated\n");
+
+    free_attribute_type(at);
+    return FALSE;
 }

struct attribute_type *load_schema(LDAP *ld, ULONG *at_count)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=68449

Your paranoid android.

=== debiant (32 bit WoW report) ===

adsldp:
ldap.c:109: Test failed: 5: got 0x8007203a, expected 0
ldap.c:114: Test failed: 5: got 0x8007203a, expected 0