Re: [PATCH 5/5] d3d11/tests: Test creation of typeless resources.

[Henri Verbeet]

On 9 February 2016 at 11:24, Józef Kucia  wrote:
> - enum resource_type
> - {
> -
>    rt_texture_2d,
> -
>    rt_texture_3d,
> - };
> -
> - static const struct
> - {
> -
>    DXGI_FORMAT format;
> -
>    D3D11_BIND_FLAG bind_flags;
> -
>    enum resource_type type;

Why not D3D11_RESOURCE_DIMENSION?

[PATCH 5/5] d3d11/tests: Test creation of typeless resources.

[Józef Kucia]

On Tue, Feb 9, 2016 at 2:03 PM, Henri Verbeet  wrote:
> On 9 February 2016 at 11:24, Józef Kucia  wrote:
> > - enum resource_type
> > - {
> > -
> >    rt_texture_2d,
> > -
> >    rt_texture_3d,
> > - };
> > -
> > - static const struct
> > - {
> > -
> >    DXGI_FORMAT format;
> > -
> >    D3D11_BIND_FLAG bind_flags;
> > -
> >    enum resource_type type;
>
> Why not D3D11_RESOURCE_DIMENSION?

D3D11 defines are so long and they tend to make test tables too wide,
but yeah, I should use D3D11_RESOURCE_DIMENSION.

[PATCH 5/5] d3d11/tests: Test creation of typeless resources.

[Henri Verbeet]

On 9 February 2016 at 14:10, Józef Kucia  wrote:
> D3D11 defines are so long and they tend to make test tables too wide,
> but yeah, I should use D3D11_RESOURCE_DIMENSION.

Yeah, there's that. For what it's worth, the initial reason this stood
out to me was that enum elements should be upper-case.