Re: Owen Rudge : comctl32: Add support for scrolling during marquee selection.

[Nikolay Sivov]

On Wed, Nov 4, 2009 at 10:26 PM, Alexandre Julliard  wrote:
> Module: wine
> Branch: master
> Commit: e1f3edef3e491095dd73548b711bddf14ee73ef0
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e1f3edef3e491095dd73548b71...
>
> Author: Owen Rudge 
> Date:   Mon Nov  2 10:58:26 2009 -0600
>
> comctl32: Add support for scrolling during marquee selection.

Hi, Owen.

I've tested this a bit and it flickers like hell in some cases. Looks
like list requests redraw even if selection doesn't change (pointer is
still over already selected item).

Other things:
- selection logic is wrong when some items are already selected before
marquee. On native it deselects those items, your code leave them as
is. This is visible in regedit (report mode listview) - select first
entry and start selection -> first item remains selected.
- sometimes I get corrupted focus rectangle - moving pointer down
causes bottom side to clear, rectangle contains three side after that
(it could be a problem for my virtual box of course, or some embedded
video drivers, but I don't see a problem moving up for example).

Owen Rudge : comctl32: Add support for scrolling during marquee selection.

[Owen Rudge]

Hi Nikolay,
> I've tested this a bit and it flickers like hell in some cases. Looks
> like list requests redraw even if selection doesn't change (pointer is
> still over already selected item).

Hmm, yes, it seems it does still redraw if you move the mouse when selecting, although it shouldn't if the mouse is stationary. Trying with regedit does show it flickering a bit. I'll see what I can do to improve this.
> - selection logic is wrong when some items are already selected before
>
> marquee. On native it deselects those items, your code leave them as
> is. This is visible in regedit (report mode listview) - select first
> entry and start selection -> first item remains selected.

This appears to be a bug that, as far as I can see, only shows up in report mode. Additionally, even if you don't select any item, the first item will be selected upon starting a drag. Items are cleared as intended when clicking, the bug seems to be that the first item in the list automatically selects itself. Again, I shall work on a patch for this.
> - sometimes I get corrupted focus rectangle - moving pointer down
>
> causes bottom side to clear, rectangle contains three side after that
> (it could be a problem for my virtual box of course, or some embedded
> video drivers, but I don't see a problem moving up for example).

I'll have a play around and see if I can reproduce this.

Cheers,

Owen