Re: [PATCH] wined3d: Add Polaris GPUs and their driver.

[Henri Verbeet]

On 13 November 2016 at 23:10, Grazvydas Ignotas  wrote:
> - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_R600,         4096},
> - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_RX,           4096},

Is that change intentional?

[PATCH] wined3d: Add Polaris GPUs and their driver.

[Grazvydas Ignotas]

On Mon, Nov 14, 2016 at 2:53 PM, Henri Verbeet  wrote:
> On 13 November 2016 at 23:10, Grazvydas Ignotas  wrote:
> > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_R600,         4096},
> > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_RX,           4096},
>
> Is that change intentional?

Yes, from looking at dxdiag output posted by various people on the
net, R9 290 is also using aticfx32.dll . I haven't checked the other
older cards, so left them alone.

Grazvydas

[PATCH] wined3d: Add Polaris GPUs and their driver.

[Henri Verbeet]

On 14 November 2016 at 14:09, Grazvydas Ignotas  wrote:
> On Mon, Nov 14, 2016 at 2:53 PM, Henri Verbeet  wrote:
> > On 13 November 2016 at 23:10, Grazvydas Ignotas  wrote:
> > > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_R600,         4096},
> > > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_RX,           4096},
> >
> > Is that change intentional?
>
> Yes, from looking at dxdiag output posted by various people on the
> net, R9 290 is also using aticfx32.dll . I haven't checked the other
> older cards, so left them alone.

Ok. For future reference, it would probably be better to make that
kind of change in a separate patch. If you (or anyone else) could
check some of the older cards as well, that would be helpful. The
different driver name may have more to do with the driver version than
with the hardware. Also, is the driver name the same for 32-bit and
64-bits processes?

[PATCH] wined3d: Add Polaris GPUs and their driver.

[Grazvydas Ignotas]

On Mon, Nov 14, 2016 at 3:37 PM, Henri Verbeet  wrote:
> On 14 November 2016 at 14:09, Grazvydas Ignotas  wrote:
> > On Mon, Nov 14, 2016 at 2:53 PM, Henri Verbeet  wrote:
> > > On 13 November 2016 at 23:10, Grazvydas Ignotas  wrote:
> > > > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_R600,         4096},
> > > > - {HW_VENDOR_AMD,        CARD_AMD_RADEON_R9,             "AMD Radeon R9 290",                DRIVER_AMD_RX,           4096},
> > >
> > > Is that change intentional?
> >
> > Yes, from looking at dxdiag output posted by various people on the
> > net, R9 290 is also using aticfx32.dll . I haven't checked the other
> > older cards, so left them alone.
>
> Ok. For future reference, it would probably be better to make that
> kind of change in a separate patch. If you (or anyone else) could
> check some of the older cards as well, that would be helpful. The
> different driver name may have more to do with the driver version than
> with the hardware.

Probably, I guess it's best to report the latest one?
> Also, is the driver name the same for 32-bit and
> 64-bits processes?

No, but the same is true for Intel driver names and wine currently
only has the 32bit ones.

[PATCH] wined3d: Add Polaris GPUs and their driver.

[Henri Verbeet]

On 14 November 2016 at 14:53, Grazvydas Ignotas  wrote:
> On Mon, Nov 14, 2016 at 3:37 PM, Henri Verbeet  wrote:
> > Ok. For future reference, it would probably be better to make that
> > kind of change in a separate patch. If you (or anyone else) could
> > check some of the older cards as well, that would be helpful. The
> > different driver name may have more to do with the driver version than
> > with the hardware.
>
> Probably, I guess it's best to report the latest one?

Yeah.
> > Also, is the driver name the same for 32-bit and
> > 64-bits processes?
>
> No, but the same is true for Intel driver names and wine currently
> only has the 32bit ones.

Right, we should probably fix that, shouldn't be too hard.