William Poetra Yoga H williampoetra@yahoo.com writes:
Index: dlls/user/menu.c
RCS file: /home/wine/wine/dlls/user/menu.c,v retrieving revision 1.8 diff -u -r1.8 menu.c --- dlls/user/menu.c 8 Nov 2004 22:12:42 -0000 1.8 +++ dlls/user/menu.c 9 Nov 2004 14:26:09 -0000 @@ -1441,8 +1441,6 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd);
- lprect->bottom = lprect->top + lppop->Height;
This doesn't look right at all, you cannot simply ignore the computed size of the menu bar, this is going to break owner drawn menus.
--- Alexandre Julliard julliard@winehq.org wrote:
William Poetra Yoga H williampoetra@yahoo.com writes:
Index: dlls/user/menu.c
RCS file: /home/wine/wine/dlls/user/menu.c,v retrieving revision 1.8 diff -u -r1.8 menu.c --- dlls/user/menu.c 8 Nov 2004 22:12:42 -0000 1.8 +++ dlls/user/menu.c 9 Nov 2004 14:26:09 -0000 @@ -1441,8 +1441,6 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd);
- lprect->bottom = lprect->top + lppop->Height;
This doesn't look right at all, you cannot simply ignore the computed size of the menu bar, this is going to break owner drawn menus.
-- Alexandre Julliard julliard@winehq.org
Oops... sorry... I overlooked the "if (lppop->Height == 0)" part... I fixed lprect->bottom in MENU_MenuBarCalcSize(), and assumed that lprect->bottom will always be correct... I'll fix the patch and resend it tomorrow.
Btw, can a person other than the one who made patch edit the patch and resubmit it? I mean, if I wrote a patch with an error in it, then can someone take the patch, fix the error, and resubmit it? Or, if you find an error (such as in this case), can you (as the one who has full access to the cvs repository) take my patch, fix it, and commit it?
I know this sounds a bit unethical (maybe impolite would be a better word), but for practical reasons I think this is permittable. Or maybe I should specifically state (at wine-patches) that I "allow anyone else to fix the patch should it contain errors, and resubmit it"?
__________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com
On Wed, Nov 10, 2004 at 04:47:15AM -0800, William Poetra Yoga H wrote:
I know this sounds a bit unethical (maybe impolite would be a better word), but for practical reasons I think this is permittable. Or maybe I should specifically state (at wine-patches) that I "allow anyone else to fix the patch should it contain errors, and resubmit it"?
This will not work, you'll need to manage your own patches into the tree.
Le mer 10/11/2004 à 10:45, Dimitrie O. Paun a écrit :
On Wed, Nov 10, 2004 at 04:47:15AM -0800, William Poetra Yoga H wrote:
I know this sounds a bit unethical (maybe impolite would be a better word), but for practical reasons I think this is permittable. Or maybe I should specifically state (at wine-patches) that I "allow anyone else to fix the patch should it contain errors, and resubmit it"?
This will not work, you'll need to manage your own patches into the tree.
Sometimes, if the original submitter hasn't updated the patch (when the reasons for it's non-commit are known) after some time and the patch is deemed useful by somebody else, that other person fixes it and resubmit.
Another thing which may happen is Alexandre fixes small issues while committing a patch, so what's in cvs isn't exactly what you sent (a cvs update will show conflicts). But don't count on that to happen all the time.
Vincent
OK, menu bar patch fixed and resent. I think it shouldn't have problems now right?
__________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com
-
Alexandre Julliard -
Dimitrie O. Paun -
Vincent Béron -
William Poetra Yoga H