[PATCH] ntdll/tests: Fix some test failures with Windows 10.

[Zebediah Figura]

Signed-off-by: Zebediah Figura 
---
 dlls/ntdll/tests/reg.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c
index 9bb8d25020..649ae484f2 100644
--- a/dlls/ntdll/tests/reg.c
+++ b/dlls/ntdll/tests/reg.c
@@ -387,7 +387,9 @@ todo_wine
     /* Open is case sensitive unless OBJ_CASE_INSENSITIVE is specified. */
     pRtlCreateUnicodeStringFromAsciiz( &str, "\Registry\Machine" );
     status = pNtOpenKey(&key, KEY_READ, &attr);
-    todo_wine ok(status == STATUS_OBJECT_PATH_NOT_FOUND, "NtOpenKey Failed: 0x%08x\n", status);
+    todo_wine ok(status == STATUS_OBJECT_PATH_NOT_FOUND || status == STATUS_SUCCESS /* Win10 1607+ */,
+            "NtOpenKey Failed: 0x%08x\n", status);
+    if (!status) pNtClose( key );

attr.Attributes = OBJ_CASE_INSENSITIVE;
     status = pNtOpenKey(&key, KEY_READ, &attr);
@@ -616,7 +618,9 @@ static void test_NtCreateKey(void)
     pRtlCreateUnicodeStringFromAsciiz( &str, "\Registry\Machine\Software\Classes" );
     status = pNtCreateKey( &subkey, am, &attr, 0, 0, 0, 0 );
     todo_wine
-    ok( status == STATUS_OBJECT_PATH_NOT_FOUND, "NtCreateKey failed: 0x%08x\n", status );
+    ok(status == STATUS_OBJECT_PATH_NOT_FOUND || status == STATUS_SUCCESS /* Win10 1607+ */,
+            "NtCreateKey failed: 0x%08x\n", status );
+    if (!status) pNtClose( subkey );
     pRtlFreeUnicodeString( &str );

pRtlCreateUnicodeStringFromAsciiz( &str, "\REGISTRY\Machine\Software\Classes" );
@@ -926,14 +930,14 @@ static void test_NtQueryLicenseKey(void)
     len = 0xbeef;
     status = pNtQueryLicenseValue(&name, NULL, buffer, sizeof(buffer), &len);
     ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "NtQueryLicenseValue returned %08x, expected STATUS_OBJECT_NAME_NOT_FOUND\n", status);
-    ok(len == 0xbeef, "expected unmodified value for len, got %u\n", len);
+    ok(len == 0xbeef || broken(!len) /* Win10 1607 */, "expected unmodified value for len, got %u\n", len);

type = 0xdead;
     len = 0xbeef;
     status = pNtQueryLicenseValue(&name, &type, buffer, sizeof(buffer), &len);
     ok(status == STATUS_OBJECT_NAME_NOT_FOUND, "NtQueryLicenseValue unexpected succeeded\n");
     ok(type == 0xdead, "expected unmodified value for type, got %u\n", type);
-    ok(len == 0xbeef, "expected unmodified value for len, got %u\n", len);
+    ok(len == 0xbeef || broken(!len) /* Win10 1607 */, "expected unmodified value for len, got %u\n", len);

pRtlFreeUnicodeString(&name);

@@ -1291,7 +1295,7 @@ static void test_symlinks(void)
     ok( status == STATUS_SUCCESS, "NtSetValueKey failed: 0x%08x\n", status );
     attr.ObjectName = &link_str;
     status = pNtOpenKey( &key, KEY_ALL_ACCESS, &attr );
-    ok( status == STATUS_SUCCESS || status == STATUS_OBJECT_NAME_NOT_FOUND,
+    ok( status == STATUS_OBJECT_NAME_NOT_FOUND || status == STATUS_OBJECT_NAME_INVALID /* Win10 1607+ */,
         "NtOpenKey wrong status 0x%08x\n", status );

key = (HKEY)0xdeadbeef;
@@ -1320,8 +1324,10 @@ static void test_symlinks(void)
     ok( status == STATUS_SUCCESS, "NtSetValueKey failed: 0x%08x\n", status );

status = pNtOpenKey( &key, KEY_ALL_ACCESS, &attr );
-    ok( status == STATUS_OBJECT_NAME_NOT_FOUND || status == STATUS_NAME_TOO_LONG,
-        "NtOpenKey failed: 0x%08x\n", status );
+    ok( status == STATUS_OBJECT_NAME_NOT_FOUND /* XP */
+            || status == STATUS_NAME_TOO_LONG
+            || status == STATUS_INVALID_PARAMETER /* Win10 1607+ */,
+            "NtOpenKey failed: 0x%08x\n", status );

attr.Attributes = OBJ_OPENLINK;
     status = pNtOpenKey( &key, KEY_ALL_ACCESS, &attr );

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=58055

Your paranoid android.

=== debian10 (32 bit report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000

=== debian10 (32 bit French report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000

=== debian10 (32 bit Japanese:Japan report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000

=== debian10 (32 bit Chinese:China report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000

=== debian10 (32 bit WoW report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000

=== debian10 (64 bit WoW report) ===

ntdll:
reg.c:621: Test succeeded inside todo block: NtCreateKey failed: 0x00000000
reg.c:390: Test succeeded inside todo block: NtOpenKey Failed: 0x00000000